[Piuparts-commits] rev 219 - in trunk: . debian piupartslib

[Holger Levsen]

Author: holger
Date: 2009-03-11 20:36:59 +0000 (Wed, 11 Mar 2009)
New Revision: 219

Modified:
   trunk/TODO
   trunk/debian/changelog
   trunk/piupartslib/packagesdb.py
Log:
Change the test whether a package is testable to check whether the 
package is of priority "required", and not whether it's "Essential".

Modified: trunk/TODO
===================================================================
--- trunk/TODO	2009-03-11 17:54:22 UTC (rev 218)
+++ trunk/TODO	2009-03-11 20:36:59 UTC (rev 219)
@@ -5,6 +5,10 @@
 exim and removing postfix would require re-installing exim, and that
 doesn't happen; there's other packages like that, too
 
+* piuparts can't currently test upgrades of requiered packages. (Because they
+cannot be removed, it assumes these are untestable, which is only true for
+removal tests...
+
 ----------------
 
 - find_default_debian_mirrors: if parts[2] contains a / (think
@@ -16,12 +20,6 @@
   the used program (to be able to test with and without recommended 
   packages or authentication).
 
-- you need to either use --allow-unauthenticated or --force-yes
-  to apt-get calls; problem: --force-yes is too dangerous and 
-  --allow-unauthenticated doesn't exist in old versions (which
-  is relevant for testing upgrades from woody upwards, for example);
-  djpig suggests using "-o APT::Get::AllowUnauthenticated=True".
-
 - mounting /proc and perhaps others (usbfs, sysfs, /dev/pts, etc.) in
   the chroot might be a good idea because some packages might need this.
   Interestingly enough this currently seems to prevent start-stop-daemon

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2009-03-11 17:54:22 UTC (rev 218)
+++ trunk/debian/changelog	2009-03-11 20:36:59 UTC (rev 219)
@@ -6,6 +6,8 @@
   * Do not install recommends and suggests.
   * Re-add piuparts-reports.py which got removed/lost between 0.14 and 0.20 
     without changelog entry.
+  * Change the test whether a package is testable to check whether the 
+    package is of priority "required", and not whether it's "Essential".
 
  -- Holger Levsen <holger at debian.org>  Tue, 10 Mar 2009 15:23:59 +0100
 

Modified: trunk/piupartslib/packagesdb.py
===================================================================
--- trunk/piupartslib/packagesdb.py	2009-03-11 17:54:22 UTC (rev 218)
+++ trunk/piupartslib/packagesdb.py	2009-03-11 20:36:59 UTC (rev 219)
@@ -82,8 +82,8 @@
         return list
 
     def is_testable(self):
-        """Are we testable at all? Essential/required/important aren't."""
-        return self.get("Essential", "") != "yes"
+        """Are we testable at all? Required aren't."""
+        return self.get("Priority", "") != "required"
 
     def dump(self, output_file):
         output_file.write("".join(self.headers))