[Piuparts-commits] [piuparts] 14/14: bug-templates: recommend dpkg-maintscript-helper symlink-to-dir/dir-to-symlink

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch develop
in repository piuparts.

commit 2b6a614d09c7855c16003bf0c606b0196cb0d617
Author: Andreas Beckmann <anbe at debian.org>
Date:   Mon Dec 9 03:35:13 2013 +0100

    bug-templates: recommend dpkg-maintscript-helper symlink-to-dir/dir-to-symlink
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>
---
 .../copyright_file_missing_after_upgrade.mail      | 23 ++++------------------
 .../unhandled_symlink_to_directory_conversion.mail | 12 ++++-------
 debian/changelog                                   |  3 +++
 3 files changed, 11 insertions(+), 27 deletions(-)

diff --git a/bug-templates/copyright_file_missing_after_upgrade.mail b/bug-templates/copyright_file_missing_after_upgrade.mail
index f3082d3..ca92d72 100644
--- a/bug-templates/copyright_file_missing_after_upgrade.mail
+++ b/bug-templates/copyright_file_missing_after_upgrade.mail
@@ -30,25 +30,10 @@ and vice versa, you need the maintainer scripts to do this.
 See in particular the end of point 4 in
 http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase
 
-For switching from a directory to a symlink the *postinst* script
-should do something like this:
-
-	DOCDIR=/usr/share/doc/@@PACKAGE@@
-	DOCLINK=@@OTHERPACKAGE@@
-
-	if [ -d $DOCDIR ] && [ ! -L $DOCDIR ]; then
-		rmdir $DOCDIR
-		ln -s $DOCLINK $DOCDIR
-	fi
-
-For switching from a symlink to a directory, the *preinst* script
-should do something like this:
-
-	DOCDIR=/usr/share/doc/@@PACKAGE@@
-
-	if [ -L $DOCDIR ]; then
-		rm $DOCDIR
-	fi
+It is recommended to use the dpkg-maintscript-helper commands
+'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2)
+to perform the conversion, ideally using d/$PACKAGE.mainstscript.
+See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.
 
 
 cheers,
diff --git a/bug-templates/unhandled_symlink_to_directory_conversion.mail b/bug-templates/unhandled_symlink_to_directory_conversion.mail
index 464404c..f98eb2e 100644
--- a/bug-templates/unhandled_symlink_to_directory_conversion.mail
+++ b/bug-templates/unhandled_symlink_to_directory_conversion.mail
@@ -33,14 +33,10 @@ and vice versa, you need the maintainer scripts to do this.
 See in particular the end of point 4 in
 http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase
 
-For switching from a symlink to a directory, the *preinst* script
-should do something like this:
-
-	DOCDIR=/usr/share/doc/@@PACKAGE@@
-
-	if [ -L $DOCDIR ]; then
-		rm $DOCDIR
-	fi
+It is recommended to use the dpkg-maintscript-helper commands
+'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.2)
+to perform the conversion, ideally using d/$PACKAGE.mainstscript.
+See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.
 
 
 From the attached log (usually somewhere in the middle...):
diff --git a/debian/changelog b/debian/changelog
index 0a324ef..79f7ae5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -40,6 +40,9 @@ piuparts (0.56) UNRELEASED; urgency=low
   * reschedule_oldest_logs: Report number of logfiles in recycle/.
   * Add more piuparts exceptions to work around various failures in multiple
     packages. Add a known_problem report for packages using exceptions.
+  * bug-templates: Recommend to use the new dpkg-maintscript-helper commands
+    dir_to_symlink/symlink_to_dir that were added in dpkg 1.17.2.
+    (Closes: #720185)
 
   [ Holger Levsen ]
   * piuparts-report.py: use descriptive link targets for (in)adequate issues

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/piuparts/piuparts.git