[Piuparts-commits] [piuparts] 01/01: Detect four more (in)adequate issues. (Closes: #767499)

Holger Levsen holger at moszumanska.debian.org
Fri Nov 7 00:37:57 UTC 2014


This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch develop
in repository piuparts.

commit 087ca50b00477c4cdf2aca12a7787b10afe04cbb
Author: Holger Levsen <holger at layer-acht.org>
Date:   Thu Nov 6 21:29:44 2014 +0000

    Detect four more (in)adequate issues. (Closes: #767499)
    
    * piuparts.yp and piuparts-report: Detect four more (in)adequate issues:
      - broken-binfmt-detector
      - broken-binfmt-interpreter
      - missing-alternative
      - program-name-collision
      (Closes: #767499)
---
 debian/changelog                                   |  6 ++++++
 known_problems/broken_binfmt_detector_issue.tpl    | 11 +++++++++++
 known_problems/broken_binfmt_interpreter_issue.tpl | 11 +++++++++++
 known_problems/missing_alternative_issue.tpl       | 11 +++++++++++
 known_problems/program_name_collision_issue.tpl    | 11 +++++++++++
 piuparts-report.py                                 |  4 ++++
 piuparts.py                                        | 12 ++++++++----
 7 files changed, 62 insertions(+), 4 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 91e5e15..93a8036 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,12 @@ piuparts (0.61) UNRELEASED; urgency=medium
   [ Holger Levsen ]
   * piuparts.py: Add "/var/cache/apt/archives/partial/" to ignored files.
     (Closes: #767489)
+  * piuparts.yp and piuparts-report: Detect four more (in)adequate issues:
+    - broken-binfmt-detector
+    - broken-binfmt-interpreter
+    - missing-alternative
+    - program-name-collision
+    (Closes: #767499)
 
  -- Holger Levsen <holger at debian.org>  Sun, 26 Oct 2014 20:19:35 +0100
 
diff --git a/known_problems/broken_binfmt_detector_issue.tpl b/known_problems/broken_binfmt_detector_issue.tpl
new file mode 100644
index 0000000..444a11f
--- /dev/null
+++ b/known_problems/broken_binfmt_detector_issue.tpl
@@ -0,0 +1,11 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .* broken-binfmt-detector'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'broken-binfmt-detector' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'broken-binfmt-detector' which indicates a bug: The detector registered with update-binfmts(8) does not exist.
+</p>
+"
diff --git a/known_problems/broken_binfmt_interpreter_issue.tpl b/known_problems/broken_binfmt_interpreter_issue.tpl
new file mode 100644
index 0000000..8335ff8
--- /dev/null
+++ b/known_problems/broken_binfmt_interpreter_issue.tpl
@@ -0,0 +1,11 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .* broken-binfmt-interpreter'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'broken-binfmt-interpreter' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'broken-binfmt-interpreter' which indicates a bug: The interpreter registered with update-binfmts(8) does not exist.
+</p>
+"
diff --git a/known_problems/missing_alternative_issue.tpl b/known_problems/missing_alternative_issue.tpl
new file mode 100644
index 0000000..20a5ca6
--- /dev/null
+++ b/known_problems/missing_alternative_issue.tpl
@@ -0,0 +1,11 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .* missing-alternative'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'missing-alternative' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'missing-alternative' which indicates a bug similar to this situation: a package is a provider of the virtual package 'x-terminal-emulator', but it  doesn't register itself as an alternative for '/usr/bin/x-terminal-emulator'. See debian-policy 11.8.3 and 11.8.4.
+</p>
+"
diff --git a/known_problems/program_name_collision_issue.tpl b/known_problems/program_name_collision_issue.tpl
new file mode 100644
index 0000000..c495dfa
--- /dev/null
+++ b/known_problems/program_name_collision_issue.tpl
@@ -0,0 +1,11 @@
+#
+# detect packages with some inadequate tag from adequate
+#
+PATTERN='(FAIL|WARN): Running adequate resulted in .* program-name-collision'
+WHERE='pass fail bugged affected'
+ISSUE=1
+HEADER="Packages tagged 'program-name-collision' by adequate"
+HELPTEXT="
+<p>Running <a href="https://packages.debian.org/adequate" target="_blank">adequate</a> resulted in the package being tagged 'program-name-collision' which indicates that this package ships a program with the same name as another program. This is a violation of debian-policy 10.1.
+</p>
+"
diff --git a/piuparts-report.py b/piuparts-report.py
index 8212273..363930c 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -430,6 +430,10 @@ linktarget_by_template = [
     ("incompatible_licenses_inadequate_issue.tpl", "but adequate found a license incompatibility"),
     ("missing_copyright_file_inadequate_issue.tpl", "but adequate couldn't find a copyright file"),
     ("py_file_not_bytecompiled_inadequate_issue.tpl", "but adequate found a .py file that is not byte-compiled"),
+    ("broken_binfmt_detector_issue.tpl", "but adequate did not find the detector registered with update_binfmts"),
+    ("broken_binfmt_interpreter_issue.tpl", "but adequate did not find the interpreter registered with update_binfmts"),
+    ("missing_alternative_issue.tpl", "but adequate found a missing alternative"),
+    ("program_name_collision_issue.tpl", "but adequate found a program name collision"),
     ("pyshared_file_not_bytecompiled_inadequate_issue.tpl", "but adequate found a .py file in /usr/share/pyshared that is not byte-compiled"),
     ("undefined_symbol_inadequate_issue.tpl", "but adequate found an undefined symbol"),
     ("symbol-size-mismatch_inadequate_issue.tpl", "but adequate found that a symbol has changed size since the package was built"),
diff --git a/piuparts.py b/piuparts.py
index 335a18c..64c220a 100644
--- a/piuparts.py
+++ b/piuparts.py
@@ -1192,15 +1192,19 @@ class Chroot:
             logging.info("Running adequate version %s now." % output.strip())
             adequate_tags = [
                     'bin-or-sbin-binary-requires-usr-lib-library',
+                    'broken-binfmt-detector',
+                    'broken-binfmt-interpreter',
+                    'incompatible-licenses',
+                    'ldd',
                     'library-not-found',
+                    'missing-alternative',
                     'missing-copyright-file',
+                    'missing-symbol-version-information',
+                    'program-name-collision',
                     'py-file-not-bytecompiled',
                     'pyshared-file-not-bytecompiled',
-                    'undefined-symbol',
-                    'missing-symbol-version-information',
                     'symbol-size-mismatch',
-                    'incompatible-licenses',
-                    'ldd',
+                    'undefined-symbol',
                     ]
             boring_tags = [
                     'obsolete-conffile',

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/piuparts/piuparts.git



More information about the Piuparts-commits mailing list