[Piuparts-commits] [piuparts] 06/07: report passed logs with attempted removal of essential packages

[Holger Levsen]

This is an automated email from the git hooks/post-receive script.

holger pushed a commit to branch develop
in repository piuparts.

commit 6e596dcb524dcbfdb0b1c847a3e8cf2ba4a5e78e
Author: Andreas Beckmann <anbe at debian.org>
Date:   Mon Mar 6 12:44:14 2017 +0100

    report passed logs with attempted removal of essential packages
    
    Essential packages were removed and -y was used without --allow-remove-essential
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>
    Signed-off-by: Holger Levsen <holger at layer-acht.org>
---
 debian/changelog                                |  2 ++
 known_problems/problems_and_no_force_issue.conf | 16 ++++++++++++++++
 piuparts-report.py                              |  1 +
 3 files changed, 19 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 9eb0edb..3f2cf1a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -39,6 +39,8 @@ piuparts (0.76) UNRELEASED; urgency=medium
     'init'.
   * Add/update exceptions for ancient packages.
   * master-bin/detect_piuparts_issues: Recognize more cases of full disks.
+  * known_problems/problems_and_no_force_issue.conf: New, recognize the
+    apt 1.1 message on attempted removal of essential packages.
   * Add bug template for failing to upgrade from testing to sid.
   * Add bug template for shipping broken symlinks.
 
diff --git a/known_problems/problems_and_no_force_issue.conf b/known_problems/problems_and_no_force_issue.conf
new file mode 100644
index 0000000..efbcc9e
--- /dev/null
+++ b/known_problems/problems_and_no_force_issue.conf
@@ -0,0 +1,16 @@
+#
+# detect packages with problems because of not enough force
+#
+PATTERN='E: Essential packages were removed and -y was used without --allow-remove-essential'
+WHERE='pass'
+ISSUE=1
+HEADER='Packages with logs reporting attempted removal of essential packages'
+HELPTEXT='
+<p>
+The piuparts logfile for these packages contains the string <pre>E: Essential packages were removed and -y was used without --allow-remove-essential</pre>, which is usually an indication, that an essential package needs to be removed to install this package. As piuparts does not use that much force, the piuparts test fails.
+</p>
+<p>
+This is usually not an error in the package and it needs to be seen how piuparts should deal with it.
+</p>
+
+'
diff --git a/piuparts-report.py b/piuparts-report.py
index ca8a5ec..c5cb0ad 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -420,6 +420,7 @@ linktarget_by_template = [
     ("unowned_files_after_purge_issue.tpl", "but logfile contains unowned files after purge"),
     ("maintainer_script_issue.tpl", "but logfile contains maintainer script failures"),
     ("db_setup_issue.tpl", "but logfile contains failure to setup a database"),
+    ("problems_and_no_force_issue.tpl", "but logfile reports that not enough force was used"),
     ("installs_over_symlink_issue.tpl", "but package installs something over existing symlinks"),
     ("broken_symlinks_issue.tpl", "but logfile contains 'broken symlinks'"),
     ("unknown_inadequate_issue.tpl", "but logfile contains unknown inadequate issues"),

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/piuparts/piuparts.git