[Piuparts-devel] Bug#440151: piuparts: should not fail in case of broken symlinks

[Lucas Nussbaum]

Package: piuparts
Version: 0.25

Hi,

When piuparts detects broken symlinks, it should not exit immediately,
but continue to test the package. I agree that broken symlinks are bad,
but it prevents from finding even more serious issues.

I would suggest adding an option "--warn-on-broken-symlinks" so that it
becomes non-fatal.

The same problem probably applies to the "files left", "files disappeared",
"processes running" errors. Maybe it would be better to add an option
"--warn-on-non-critical-error" or something like that?

An example package that fails is firebird2-common:
  Unpacking firebird2-common (from .../firebird2-common_1.5.3.4870-12_all.deb) ...
  Adding system user `firebird' (UID 100) ...
  Adding new group `firebird' (GID 103) ...
  Adding new user `firebird' (UID 100) with group `firebird' ...
  Creating home directory `/var/lib/firebird2' ...
  Setting up firebird2-common (1.5.3.4870-12) ...
0m3.4s DEBUG: Command ok: ['chroot', '/tmp/tmpN7CvD5', 'apt-get', '-y', 'install', 'firebird2-common']
0m3.4s DEBUG: Starting command: ['chroot', '/tmp/tmpN7CvD5', 'apt-get', 'clean']
0m3.4s DEBUG: Command ok: ['chroot', '/tmp/tmpN7CvD5', 'apt-get', 'clean']
0m3.4s DEBUG: Starting command: ['lsof', '+D', '/tmp/tmpN7CvD5']
0m3.7s DEBUG: Command failed (status=1), but ignoring error: ['lsof', '+D', '/tmp/tmpN7CvD5']
0m3.9s ERROR: Broken symlinks:
  /usr/lib/firebird2/firebird.log -> True
  /usr/lib/firebird2/help -> True
0m3.9s DEBUG: Starting command: ['chroot', '/tmp/tmpN7CvD5', 'umount', '/proc']
0m3.9s DEBUG: Command ok: ['chroot', '/tmp/tmpN7CvD5', 'umount', '/proc']
0m4.0s DEBUG: Removed directory tree at /tmp/tmpN7CvD5
-- 
| Lucas Nussbaum
| lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |