[Piuparts-devel] Bug#431248: Bug#431248: piuparts: AssertionError

[John Wright]

tags 431248 +pending
thanks

On Wed, Jul 04, 2007 at 06:09:43PM +0200, Ana Guerrero wrote:
> On Sun, Jul 01, 2007 at 04:45:44PM +1000, Aníbal Monsalve Salazar wrote:
> > I'm getting the following messages after upgrading piuparts today:
> > 
> > Traceback (most recent call last):
> >   File "/usr/sbin/piuparts", line 1232, in ?
> >     main()
> >   File "/usr/sbin/piuparts", line 1217, in main
> >     if install_and_upgrade_between_distros(args, packages):
> >   File "/usr/sbin/piuparts", line 936, in install_and_upgrade_between_distros
> >     root_info = chroot.save_meta_data()
> >   File "/usr/sbin/piuparts", line 621, in save_meta_data
> >     assert dirpath[:4] == root
> > AssertionError
> >
> 
> This bug is caused by m4. From piuparts-0.21/Makefile :
> 
> piuparts.py: piuparts.py.in
>     m4 -D __PIUPARTS_VERSION__=$$(dpkg-parsechangelog | grep ^Version: \
> 	    | cut -d' ' -f2) < $< > $@
> 
> m4 not only replaces __PIUPARTS_VERSION__ for the current version, it makes
> another weird substitutions in the piuparts.py that triggers this problem.
> [1]. If somebody speaks m4 and know what this happens please share it :D

Ok, fixed by using m4's "-P" option.  Now, we get something more like
what was indended:


john at supernova:~/debian/piuparts/trunk$ make piuparts.py
m4 -P -D __PIUPARTS_VERSION__=$(dpkg-parsechangelog | grep ^Version: | cut -d' ' -f2) < piuparts.py.in > piuparts.py
john at supernova:~/debian/piuparts/trunk$ diff -u piuparts.py.in piuparts.py
--- piuparts.py.in      2007-07-03 23:34:30.000000000 -0600
+++ piuparts.py 2007-07-04 11:10:07.000000000 -0600
@@ -30,7 +30,7 @@
 """


-VERSION = "__PIUPARTS_VERSION__"
+VERSION = "0.22"


 import time


I've committed the fix...

John