[Piuparts-devel] Bug#478577: piuparts: debfoster requires /proc/stat

[Tobias Grimm]

> Feature request: please also check where /proc should be ignored in
> piuparts code. One place I found is the code for the '-s' option (save
> tarball), which now generates a tar of my /proc

You're right, I missed to test this case.

I think writing back the tarball is the only place, where /proc
should not be mounted. It would be nice, if /proc/* could simply
be excluded, but this is possible only in Python 2.6.

I modified the patch (see attachment), which now changes these things:

1. moves mount_proc() to the ctor of the Chroot class, eliminating
the need to call it from various places. /proc is mounted as soon
as the chroot is configured. For exporting the chroot to a tarball,
/proc gets unmounted first and mounted again afterwards.

2. Did some small refactorings to the ctor code of the Chroot class
to elimintate some duplication and a double call of apt-get update.

3. Allow the tarball to be written also with -s, when -b is used. This
might be useful, to get an updated and minimized tarball from the
base.tar.gz provided with the -b argument.

Tobias


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: piuparts-mountproc-3.diff
Url: http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20080501/e616d12e/attachment.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20080501/e616d12e/attachment.pgp