[Piuparts-devel] Bug#559449: Bug#559449: piuparts: please add LVM support [PATCH]

[Patrick Schoenfeld]

Hi,

On Fri, Dec 04, 2009 at 03:38:37PM +0100, Holger Levsen wrote:
> tags 559449 + confirmed
> thanks
> 
> Hi Patrick,
> 
> thanks for your bugreport with patch!
> 
> On Freitag, 4. Dezember 2009, Patrick Schoenfeld wrote:
> > I'd like to use piuparts but neither with creating a new chroot on every
> > run, nor by unpacking a tarball on every run, but with LVM snapshots.
> > There is a bug report about adding schroot support, but I didn't see any
> > benefit of using schroot in contrast to just using LVM snapshots,
> 
> less requierements (=no lvm) to use it?

I don't get that, because I don't see what benefits this would provide
over using the methods piuparts is already to.. oh wait. There is one:
With schroot piuparts could run without root permissions. Ok, I don't
care to much about it, but anyone else sureley does :)

> > so 
> > I implemented the latter. My patch is attached. Feel free to apply it
> > or if you have any questions/comments get back to me.
> 
> Looks good to me, will apply. Right now I just don't get how this is related:

Oops. That was an accident.

> Could you also please provide a patch for piuparts.1.txt? ;-) Extra bonus points for a 
> debian/changelog entry ;-)

See new attached patch.

Best Regards,
Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: piuparts-lvm.patch
Type: text/x-diff
Size: 5337 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20091204/d8a5a307/attachment.patch>