[Piuparts-devel] Bug#519017: piuparts: dies horribly on systems with selinux disabled but selinux-utils installed

[Peter De Wachter]

Package: piuparts
Version: 0.34
Severity: important
Tags: patch

On systems that don't have selinux enabled enabled but which have
selinux-utils installed, piuparts dies a horrible recursive death. It
tries to run /usr/sbin/selinuxenabled, which fails, which causes the
panic handlers to run, which try to run /usr/sbin/selinuxenabled,
which fails, which causes the panic handlers to run, ad infinitum (or
at least until python decides that the maximum recursion depth is
exceeded).

--- a/piuparts.py
+++ b/piuparts.py
@@ -1245,7 +1245,7 @@ class VirtServ(Chroot):
 
 def selinux_enabled(enabled_test="/usr/sbin/selinuxenabled"):
     if os.access(enabled_test, os.X_OK):
-        retval, output = run([enabled_test])
+        retval, output = run([enabled_test], ignore_errors=True)
         if retval == 0:
             return True
         else:



-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/1 CPU core)
Locale: LANG=nl_BE.UTF-8, LC_CTYPE=nl_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages piuparts depends on:
ii  apt                        0.7.21~exp1   Advanced front-end for dpkg
ii  debootstrap                1.0.11        Bootstrap a basic Debian system
ii  lsb-release                3.2-20        Linux Standard Base version report
ii  lsof                       4.81.dfsg.1-1 List open files
ii  python                     2.5.4-2       An interactive high-level object-o
ii  python-debian              0.1.12        Python modules to work with Debian

piuparts recommends no packages.

piuparts suggests no packages.

-- no debconf information