[Piuparts-devel] Bug#519192: better handling of missing configurationn settings

[Holger Levsen]

package: piuparts
version: 0.35

Hi,

as the upgrade test from etch to lenny causes failures in many packages, I 
configured piuparts-slave today not to do upgrade test by commenting out
the following lines in piuparts-slave.conf:

#upgrade-test-distros = etch lenny sid
#upgrade-test-chroot-tgz = etch.tar.gz

Unfortunatly that was responded with a nice traceback error:

Traceback (most recent call last):
  File "share/piuparts/piuparts-slave.py", line 408, in <module>
    main()
  File "share/piuparts/piuparts-slave.py", line 385, in main
    distros = [config["distro"]] + config["upgrade-test-distros"].split()
AttributeError: 'NoneType' object has no attribute 'split'

The workaround is easy:

upgrade-test-distros = 
upgrade-test-chroot-tgz = 

It would be nice if proper checks on variables used could be implemented, so 
that they are set to an empty value and the program does what's expected.


regards,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20090310/e3c841fd/attachment.pgp