[Piuparts-devel] Bug#573904: Bug#573904:

[Holger Levsen]

tags 573904 + pending
thanks

Hi Cleto,

inspired by your patch I now have applied (r679) a much simpler one:

--- piuparts.py (revision 678)
+++ piuparts.py (working copy)
@@ -426,7 +426,7 @@
     # Inspired by pbuilder's pbuilder-satisfydepends-aptitude
 
     tmpdir = tempfile.mkdtemp(dir=settings.tmpdir)
-    os.makedirs(os.path.join(tmpdir, name, 'DEBIAN'))
+    os.makedirs(os.path.join(tmpdir, name, 'DEBIAN'), mode = 0755)
     control = deb822.Deb822()
     control['Package'] = name
     control['Version'] = '0.invalid.0'

piuparts checks at the beginning if it's running as root (and refuses to run 
if it doesn't) so IMO your error checking code is not needed. 

(Granted, error checking is supposed to be always "good", but it also makes 
the code less readable and in this case IMO for no win.)


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20100420/10001bbe/attachment.pgp>