[Piuparts-devel] Bug#574936: Bug#574936: piuparts: Option 'do-not-verify-signatures' makes piuparts fail

[Cleto Martin Angelina]

Hi, Holger!

> a.) your patch to delete empty arguments seems to modify the arguments, did
> you test if everything still works: (?)
>
>>>> command = 'huhu huhu'
>>>> command = [x for x in command if x]
>>>> print command
> ['h', 'u', 'h', 'u', ' ', 'h', 'u', 'h', 'u']
>>>> command = 'huhu huhu'
>>>> print command
> huhu huhu

In your example, 'command' is a string, but in piuparts code a command
is a list of strings. Thus:

command = ['huhu', '', 'huhu']
command = [x for x in command if x]
print command
['huhu', 'huhu']

Unless I missed something, function run requires a list of string. In
fact, there is an assertion cheking it. Probably, the code is too
general because it eliminates empty strings and None args. But I don't
see any problem on that way.


> b.) what is the debian_bundle issue?

Sorry about my poor explanation. In sid, if you import debian_budle
you get this message:

import debian_bundle
/usr/bin/ipython:1: DeprecationWarning: please use 'debian' instead of
'debian_bundle'
  #!/usr/bin/python

The issue is only the warning message. That's all :-)

Thanks for your attention, Holger (and for your patience).

Regards,
Cleto.