[Piuparts-devel] Bug#589498: piuparts: add more locations for hooks

[Andreas Beckmann]

Package: piuparts
Version: 0.39~svn
Severity: wishlist
Tags: patch

Hi,

that attached patches add more locations where hook scripts can be
executed:

* pre_iup: at the beginning of the install-upgrade-test, before
  installing the "old" version, there was no hook available before
  (choose a better name if you like), post_setup is not an alternative
  because it is executed before taking the snapshot.
* pre_ip: at the beginning of the install-purge-test (choose a better
  name ...) pre_install could be used for this, but pre_install is
  executed in the install-upgrade-test in a different context, so it may
  not fit
* post_upgrade: after performing the upgrade, before starting removal.
  Again post_install/post_remove could be used, but they are used in
  different contexts, too.

The additional hooks in the install-upgrade-test are needed to test
interaction with related packages that might be installed before/after
the old packages or removed before/after upgrading to the new version.
Especially interesting to ensure correct behaviour of diversions.

There was a check_for_broken_symlinks missing after performing the
upgrade (that's the interesting point in time), so I added one there,
too. Or was the test just executed too early? There are already several
calls.

The second patch only moves the check for scriptsdir into run_scripts,
so it does not have to be duplicated everywhere.

Patches are vs. SVN r690 (+ my previous patches applied).


For the distupgrade hook scripts I suggest to pass the new
distribution as a parameter.


Andreas

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (800, 'testing'), (800, 'stable'), (600, 'unstable'), (130, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-0-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages piuparts depends on:
ii  apt                        0.7.25.3      Advanced front-end for dpkg
ii  debootstrap                1.0.23        Bootstrap a basic Debian system
ii  lsb-release                3.2-23.1      Linux Standard Base version report
ii  lsof                       4.81.dfsg.1-1 List open files
ii  python                     2.6.5-5       An interactive high-level object-o
ii  python-debian              0.1.16        Python modules to work with Debian

piuparts recommends no packages.

Versions of packages piuparts suggests:
ii  ghostscript                 8.71~dfsg2-3 The GPL Ghostscript PostScript/PDF
pn  python-rpy                  <none>       (no description available)

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: piuparts_03_add-more-hooks.diff
Type: text/x-diff
Size: 1219 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20100718/bec0ff4b/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: piuparts_04_check-scriptsdir-once.diff
Type: text/x-diff
Size: 4661 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20100718/bec0ff4b/attachment-0001.diff>