[Piuparts-devel] Bug#632924: Bug#632924: piuparts-slave to recreate tarball(s) beyond certain age

[Scott Schaefer]

On 07/09/2011 07:08 PM, Holger Levsen wrote:
> Hi Scott,
>
> On Donnerstag, 7. Juli 2011, Scott Schaefer wrote:
>    
>> Attached patch resolves two items:
>>      
> please dont do this. always fix seperate issues in seperate patches.
>    
OK.  That's one of those issues that, at least in my experience, 
different people prefer to handle in different manner.   I prefer one 
patch/issue myself, but my day job involves people who prefer one 
patch/sourcefile for script environments.  Oldsters who haven't made the 
transition to thinking in "changesets" ... 8 years younger than I am :-)
>
>    
>> 1) From TODO ...
>>
>> piuparts-slave: if chroot.tgz is older than N days, regenerate it
>> - currently this is done via ~piupartss/crontab, but that's a hack
>> - only throw away tarballs (and recreate them) after testing that they can
>> be recreated
>>
>> I hard-coded the MAX_TGZ_AGE at 30 days.  Log entry is written when the
>> file is recreated due to becoming too old.  The "old" file is renamed to
>> .old so that,
>> should the new file fail to be created, it is simply renamed back and
>> processing
>> continues.
>>
>> piatti crontab entry should be removed after install.
>>      
> this part looks good - except the hardcoding of MAX_TGZ_AGE - I'd prefer it to
> be the default, but thats rather minor.
>
> will merge it ASAP, just not tonight :-)
>
>    
Agree this should be a conf file item in long term.

>> 2) Bug in piuparts-slave which prevented running a single section (by
>> including section name as command-line argument).
>>      
> heh. I think I introduced this bug and never noticed as I never do that.
> Thanks for catching it!
>
>
> cheers,
> 	Holger
>