[Piuparts-devel] Bug#589498: [PATCH 1/2] check for settings.scriptsdir inside run_scripts()

[Holger Levsen]

Hi, 

On Sonntag, 6. November 2011, Andreas Beckmann wrote:
> move the check for settings.scriptsdir inside run_scripts(),
> no need to replicate it before every call

this sounds like a good idea, but have you tested this patch:
 
>      def run_scripts (self, step):
>          """ Run custom scripts to given step post-install|remove|purge"""
> 
> +        if settings.scriptsdir is None:
> +            return

settings is not defined here... :(


cheers,
	Holger