[Piuparts-devel] Bug#668863: Make piuparts-slave.py default to sid

[dsteele at gmail.com]

On Apr 15, 2012, at 10:35 AM, Andreas Beckmann <debian at abeckmann.de> wrote:

> On 2012-04-15 16:12, Holger Levsen wrote:
>>> Without the patch, Section.run() terminates with an unhandled
>>> exception, due to a reference the unassigned variable 'distro' (line
>>> 389), if the 'distro' configuration parameter is not defined.
>> 
>> Did you test this with an upgrade configuration, like testing2sid or 
>> squeeze2wheezy? I seem to recall that setting "distro" for these tests will 
>> cause unwanted consequences.
> 
> setting both distro and upgrade-test-distros is not problematic (at
> least in my heavily patched instance), but I think a section without
> both distro and upgrade-test-distros is not well-formed ... defaulting
> to something unrelated may cause more problems for upgrade tests.
> I'll fix the slave to print an error and skip the bad section.
> 

Sounds good