[Piuparts-devel] --*end-meta broken

[Holger Levsen]

Hi,

On Sonntag, 15. Januar 2012, Andreas Beckmann wrote:
> >>> Seems --save-end-meta is not working at all.
> these options were parsed into opts but not copied to settings ...

Ah.
 
> piuparts.git fix/settings  (on top of branch documentation)
> Andreas Beckmann (3):
>       cleanup options and settings
>       reorder settings
>       actually enable --*end-meta

thanks, merged.
 
> > What's the usecase anyway? The manpage says "Mostly useful for large
> > scale
> No user noticed that these options were not working ...

Yup :/
 
> > distro upgrade tests." but we're doing that anyway, without using that
> > option.
> 
> Pro: saves doing the dummy upgrades to construct the reference chroot to
> compare with
> Con: to use this effectively one needs to distinguish failures that are
> caused by outdated meta info after a mirror update

IMO the Con overweights the Pro and we should remove this now fixed option.
Maybe release 0.43 with the option fixed, and then remove it in the beginning 
of the 0.44 "cycle"?!


cheers,
	Holger