[Piuparts-devel] Bug#530733: piuparts: [PATCH] This patch is against 0.44 and work on git revision of today

[Andreas Beckmann]

Hi Mehdi,

On 2012-06-06 19:49, Mehdi Abaakouk wrote:
> I have recently setup the piupart tools on a package builder server
> My server use schroot with aufs to build package, so to reuse my setup 
> I made a patch to support schroot in piuparts.

thanks for your patch.

What about appending "-piuparts" to the schroot session, just in case
some sessions do not get cleaned up properly to make the origin clear.

In Chroot.remove() do not introduce the big schroot condition, but use
something like the following to keep further extensions simple:

if not keep:
	if not schroot:
		umount
	if lvm:
		umountlvm
	if schroot:
		terminateschroot
	if not schroot:
		rmtree
else
	if schroot:
		print keeping schroot session
	else
		print keeping tree

Please document the new option in piuparts.1.txt.

You could provide a changelog entry as well.

Please test the badly behaving package mini-buildd-bld with your patch.
The test should be terminated after a timeout of 30 minutes (you can
reduce the timeout by editing the source) because the maintainer scripts
run in a loop and the session should be cleaned up properly afterwards
and no processes must be remaining.

Andreas