[Piuparts-devel] Bug#658044: Bug#658044: Bug#658044:

[Holger Levsen]

Hi Leo,

On Donnerstag, 24. Mai 2012, Leo Iannacone wrote:
> You can find an updated version of the patch (fixing type and hunks
> succeeded with offeset) as attachment.

thanks for updating the patch!

this looks a bit unclean to me, why include those two commented out lines: ?

+    def setup_from_dir(self, dirname):
+        """Create chroot from an existing one."""
+        logging.debug("Copying %s into %s" % (dirname, self.name))
+        for name in os.listdir(dirname):
+            src = os.path.join(dirname, name)
+            dst = os.path.join(self.name, name)
+            run(["cp", "-ax", src, dst])
+            # copytree does not work with sockets
+            #shutil.copytree(src, dst, symlinks=True)

And extra points if you provide a debian/changelog entry too ;-)


cheers,
	Holger