[Piuparts-devel] sort-issues-by-rdep-fast

[Andreas Beckmann]

On 2013-04-05 13:40, Andreas Beckmann wrote:
> On 2013-04-04 15:51, Andreas Beckmann wrote:
>> On 2013-03-25 13:26, Holger Levsen wrote:
>>>> sort-issues-by-rdep-fast (5)
>>
>>> merged+pushed into develop, as per plan :-)
>>
>> I haven't looked at these into detail, but some issues I mentioned long
>> ago seem still present:
>>
>> * please rename INCLUDE to REGEX or PATTERN
>> * rename EXCLUDE to EXCLUDE_xxx accordingly
> or IGNORE_xxx
> 
>> * only insert known keys from kpr.conf
>>
>> * there is no error handling if a kpr.conf does not set one of the
>> required values, probably resulting in a KeyError later on ...

there we go:

$ PYTHONPATH=/org/piuparts.debian.org/lib/python2.6/dist-packages:/org/piuparts.debian.org/lib/python2.7/dist-packages detect_well_known_errors
Traceback (most recent call last):
  File "/local/piuparts/piupartsm/bin/detect_well_known_errors", line 508, in <module>
    problem_list = create_problem_list( conf['known-problem-directory'] )
  File "/local/piuparts/piupartsm/bin/detect_well_known_errors", line 481, in create_problem_list
    plist = [Problem(os.path.join(pdir,x)) for x in pfiles]
  File "/local/piuparts/piupartsm/bin/detect_well_known_errors", line 110, in __init__
    self.inc_re = re.compile( self.INCLUDE )
AttributeError: Problem instance has no attribute 'INCLUDE'

dwke should report all invalid .conf files it encounters and skip them


>> * WKE_Config: please use the same defaults as in piuparts-report.py

Andreas