[Piuparts-devel] Fwd: faster-rdep-calc/rdep-chain-len

[Dave Steele]

<wrong address again>

On Sun, Apr 14, 2013 at 6:49 AM, Andreas Beckmann <anbe at debian.org> wrote:
> On 2013-04-14 00:36, Dave Steele wrote:
>
> returning -1 gives a perfectly sortable integer result without any need
> for the caller to check validity - and it moves the "bad" logs to the
> bottom of the list

Not sure that is true. In any case, there are other rdep metrics.

>
>> ... I've added AttributeError to the catches.
>
> I don't like this usage for exceptions, especially catching random
> KeyErrors that break on simple changes. With the accessors doing proper
> checking, all the try/excepts in that context can go away.
> ...
> Exception handling is primarily needed for IOError etc. if a file
> disappears after we have found it's name.
> And that happens all the time :-)
> ...
> -report does lookup on package names from the db
> dwke does lookup on (package) names found in the filesystem
>

So it sounds like the ultimate solution is to rely on the package
library in detect_well_known_errors to guarantee consistency.  This
would be part of the integration of detect_well_known_errors into
piuparts-report.