[Piuparts-devel] pull: for-holger

[Andreas Beckmann]

On 2013-04-15 19:57, Dave Steele wrote:
> On Mon, Apr 15, 2013 at 5:34 AM, Andreas Beckmann <anbe at debian.org> wrote:
>>       p-r,dwke,lib/db: add explicit compute_package_states()
> ...meaning you want to keep the chdir's.

primarily making the current situation clear, s.t. fixing the chdir can
be postponed until we decided how to do it properly and after checking
whether relative directories work at all (or whether this is a good idea)

> You're going to change your
> mind on this - there are going to be more calls for the library to be
> able to work in the directory tree after initialization.
> 
> The complaint was memory for the longer log file paths, right?. I work
> this out to an issue of 0.1% of a gigabyte needed for the db. This
> while the packagesdb memory load in your instance is down by over an
> order of magnitude in the last year.

good :-)

> If the extra memory is a concern, you can store the prefix centrally,
> and build the full log paths on the fly.
> 
> To be honest about this path, you should pull the lazy logic from the
> library, and just make sure the code calls an exception in these
> cases.

>   574 +    def compute_package_states(self):
>   575 +        # this must be called with cwd == master-directory
>   576 +        self._compute_package_states()

> Really? After some of the changes you've called for in my code, this
> just ... really?

This *is* the current situation. Just documented. And to be changed.

Andreas