[Piuparts-devel] Bug#698526: Sort known issues by reverse dependency count
dsteele at gmail.com
Wed Feb 27 02:45:34 UTC 2013
On Tue, Feb 26, 2013 at 5:50 PM, Andreas Beckmann <anbe at debian.org> wrote:
> In branch report-problem_integration you have
> 4db22544 "piuparts-report - add known Problems class list to Section."
> That should be dropped, ...
This is where we have been talking past each other for the last week.
That patch is not in sort-issues-by-rdep*. It is not part of the
submission under review.
I know that we are unlikely to agree that fast-report et al are a
valid next step to known_problem conf file integration, and that they
are unlikely to be accepted. If it would help focus the conversation,
I will delete those branches entirely.
> I'm primarily concerned about reimplementing a bad piece of code (the
> second half of dwke that creates the .tpl files) in order to build a new
> feature on top of it. The perfectionist in me would like to fix things
> properly first.
The perfectionist in me also led to this series of patches, which "fix
things properly first". You and I are actually on the same sheet of
music when it comes to what this code should ultimately look like. The
only difference, and this is annoyingly minor, is the priority order,
and the resulting path to get there. You are focused on the tpl files
as the next big thing. I focused on linktarget_by_template. That's it.
Given that fact, it's going to be frustrating to toss the code.
The .tpl files come from an impedance mismatch between bash and
python. Consider the current submission of a bash-to-python conversion
a necessary first step on the path to get there.
> I really do like the approach of reviewing patches before inclusion as
> more eyes may spot more problems - and may result in a different
> implementation (e.g. recently embedding get_config_value.inl -> sourcing
I agree, and have given you visibility into what I'm working on. I'm
sure you've seen a couple of topics in github that we haven't
discussed yet. That's a good thing.
But, be aware that the current message I am getting is that it is a
bad idea to show you anything beyond small incremental submissions. It
would be immensely helpful to me if you could segment your feedback
based on submission status.
More information about the Piuparts-devel