[Piuparts-devel] Fwd: Elevate broken symlinks to error status

[Dave Steele]

Forwarding from BTS is apparently not working. Reply and forward to
699059 at bugs.debian.org.

---------- Forwarded message ----------
From: "Dave Steele" <dsteele at gmail.com>
Date: Jan 26, 2013 4:37 PM
Subject: Elevate broken symlinks to error status
To: <submit at bugs.debian.org>
Cc:

> Package: piuparts
> Severity: wishlist
> Tags: patch
> thanks
>
>
> Provide better visibility to problems with broken symlinks in packages
> by raising the condition from an issue to an error on piatti.
>
> Per
http://lists.alioth.debian.org/pipermail/piuparts-devel/2013-January/003424.html
> , the failed count will rise by no more than 500 due to this change,
> even if nothing is done to fix the errors. The rise will be gradual,
> taking about 6 months for all of the packages to recycle.
>
> Since both blockers and block-ees will migrate only as the packages
> are upgraded or recycled, it should be fairly easy to keep the
> dependency-failed count due to this error to well under 1000.
>
> https://github.com/davesteele/piuparts/commit/symlink-error
>
>
> I don't run the piatti configuration. The configuration file change is
> trivial but untested.
>
>
> ---
>  debian/changelog                          |    3 +++
>  instances/piuparts.conf.piatti            |    2 +-
>  known_problems/broken_symlinks_error.conf |    2 +-
>  known_problems/broken_symlinks_issue.conf |    2 +-
>  piuparts-report.py                        |    2 +-
>  5 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/debian/changelog b/debian/changelog
> index 5186305..10db500 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -22,6 +22,9 @@ piuparts (0.50) UNRELEASED; urgency=low
>    * slave_{run,join,cleanup}: Use pgrep to find running processes.
>    * detect_leftover_processes: Move statefile to slave-directory.
>
> +  [ David Steele ]
> +  * Elevate 'broken symlinks' to error status on piatti.
> +
>   -- Andreas Beckmann <debian at abeckmann.de>  Tue, 15 Jan 2013 11:51:43
+0100
>
>  piuparts (0.49) unstable; urgency=low
> diff --git a/instances/piuparts.conf.piatti
b/instances/piuparts.conf.piatti
> index f41ac5b..df81e70 100644
> --- a/instances/piuparts.conf.piatti
> +++ b/instances/piuparts.conf.piatti
> @@ -34,7 +34,7 @@ reschedule-fail-count = 15
>  [sid]
>  precedence = 1
>  description = Debian sid / main: package installation, removal and purge
test.
> -piuparts-flags = --scriptsdir /etc/piuparts/scripts-leftovers
> +piuparts-flags = --scriptsdir /etc/piuparts/scripts-leftovers
> --fail-on-broken-symlinks
>  # Once there are no packages left which leave files on purge behind,
>  # --pedantic-purge-test should be added
>  distro = sid
> diff --git a/known_problems/broken_symlinks_error.conf
> b/known_problems/broken_symlinks_error.conf
> index 580b184..135ba05 100644
> --- a/known_problems/broken_symlinks_error.conf
> +++ b/known_problems/broken_symlinks_error.conf
> @@ -6,5 +6,5 @@ WHERE='fail bugged affected'
>  ISSUE=1
>  HEADER='Packages which have logs with the string "Broken symlinks"'
>  HELPTEXT='
> -<p>This is clearly an error, but as there are too many of this kind,
> piuparts can be configured to not fail if it detects broken symlinks.
> Another option is not to test for broken symlinks. See the <a
> href="http://piuparts.debian.org/doc/piuparts.1.html"
> target="_blank">piuparts manpage</a> for details.</p>
> +<p>Symlinks remaining after the targets are deleted.</p>
>  '
> diff --git a/known_problems/broken_symlinks_issue.conf
> b/known_problems/broken_symlinks_issue.conf
> index 5cdfafe..1e17460 100644
> --- a/known_problems/broken_symlinks_issue.conf
> +++ b/known_problems/broken_symlinks_issue.conf
> @@ -6,5 +6,5 @@ WHERE='pass'
>  ISSUE=1
>  HEADER='Packages which have logs with the string "Broken symlinks"'
>  HELPTEXT='
> -<p>This is clearly an error, but as there are too many of this kind,
> piuparts can be configured to not fail if it detects broken symlinks.
> Another option is not to test for broken symlinks. See the <a
> href="http://piuparts.debian.org/doc/piuparts.1.html"
> target="_blank">piuparts manpage</a> for details.</p>
> +<p>Symlinks remaining after the targets are deleted.</p>
>  '
> diff --git a/piuparts-report.py b/piuparts-report.py
> index ab84c56..58dd6bc 100644
> --- a/piuparts-report.py
> +++ b/piuparts-report.py
> @@ -353,6 +353,7 @@ linktarget_by_template = [
>      ("obsolete_conffiles_issue.tpl", "but logfile reports obsolete
conffiles"),
>
>      ("dependency_error.tpl", "due to unsatisfied dependencies"),
> +    ("broken_symlinks_error.tpl", "due to 'broken symlinks'"),
>      ("packages_have_been_kept_back_error.tpl", "...and logfile also
> contains 'packages have been kept back'"),
>      ("command_not_found_error.tpl", "due to a 'command not found'
error"),
>      ("files_in_usr_local_error.tpl", "due to files in /usr/local"),
> @@ -380,7 +381,6 @@ linktarget_by_template = [
>      ("cron_error_after_removal_error.tpl", "due to errors from
> cronjob after removal"),
>      ("logrotate_error_after_removal_error.tpl", "due to errors from
> logrotate after removal"),
>      ("installs_over_symlink_error.tpl", "...and package installs
> something over existing symlinks"),
> -    ("broken_symlinks_error.tpl", "...and logfile also contains
> 'broken symlinks'"),
>      ("obsolete_conffiles_error.tpl", "...and logfile reports obsolete
> conffiles"),
>      ("unknown_failures.tpl", "due to unclassified failures"),
>  ]
> --
> 1.7.10.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20130126/aaa7ae9a/attachment-0001.html>