[Piuparts-devel] Bug#710350: piuparts-slave: slave call sudo but it is package dependency

[Zdenek Crha]

Package: piuparts-slave
Version: 0.52
Severity: important

When installing piuparts packages on clean machine, I've got following error
when trying to run slave
through piuparts_slave_run command:

zcrha-single-1:/var/lib/piuparts/slave#
zcrha-single-1:/var/lib/piuparts/slave# cd /var/lib/piuparts/slave/1
zcrha-single-1:/var/lib/piuparts/slave/1# /usr/share/piuparts/piuparts-slave
15:49:19 Creating new tarball /var/cache/piuparts/basetgz/wheezy_amd64.tar.gz
Traceback (most recent call last):
  File "/usr/share/piuparts/piuparts-slave", line 936, in <module>
    main()
  File "/usr/share/piuparts/piuparts-slave", line 891, in main
    sections.append(Section(section_name, persistent_connection))
  File "/usr/share/piuparts/piuparts-slave", line 356, in __init__
    self._check_tarball()
  File "/usr/share/piuparts/piuparts-slave", line 416, in _check_tarball
    self._config.get_start_distro())
  File "/usr/share/piuparts/piuparts-slave", line 854, in
create_or_replace_chroot_tgz
    create_chroot(config, tgz, distro)
  File "/usr/share/piuparts/piuparts-slave", line 825, in create_chroot
    p = subprocess.Popen(command, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1259, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

I've tracked the error to the missing 'sudo' command. I did not have sudo
package installed
and it is not part of piuparts-slave dependencies, even though it is used. The
dependency is only  documented
in /usr/share/doc/piuparts/README.txt.gz

I find it strange that package installs sudo configuration
(/etc/sudoers.d/piuparts) but does not ensure that dependency
is actually installed.



-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages piuparts-slave depends on:
ii  adduser          3.113+nmu3
ii  openssh-client   1:6.0p1-4
ii  piuparts         0.52
ii  piuparts-common  0.52
ii  python           2.7.3-5
ii  screen           4.1.0~20120320gitdb59704-7

piuparts-slave recommends no packages.

Versions of packages piuparts-slave suggests:
ii  schroot  1.6.5-1

-- Configuration Files:
/etc/sudoers.d/piuparts [Errno 13] Permission denied: u'/etc/sudoers.d/piuparts'

-- no debconf information