[Piuparts-devel] Fwd: Re: RFC: feature/adequate-tags

[Holger Levsen]

Hi Andreas,

thanks for the review!

On Donnerstag, 30. Mai 2013, Andreas Beckmann wrote:
> If I understand correctly, adequate produces "non-inheriting" errors (by
> testing only the requested set of packages), so there is no need to fail
> the test (and block other packages from being tested), given we properly
> report these as errors - and your branch will generate nice individual
> reports for pass/ logs.

Jup. That's why there is --fail-if-inadequate if you really want piuparts to 
fail if "only" adequate fails. 
 
> This does not work:
> 
> -    ("inadequate_error.tpl", "due to logfile containing inadequate
> errors"),
> +    ("inadequate_exit_issue.tpl", "due to adequate exiting inadequately"),
> 
> IIRC the _error.tpl vs. _issue.tpl suffix is currently a significant
> property used in piuparts-report.

Yup, I've changed this to exit_issue.tpl. (Re-fetch.)
 
> So maybe just restore inadequate_error.tpl for the time being to have a
> separate combined report of all adequate output in fail/ and friends -
> the tests din't fail because of adequate anyway so splitting them up for
> fail/ is not really helpful.

I think the current/latest branch (fc4207e) is ok.


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20130530/4845ea16/attachment-0001.pgp>