[Piuparts-devel] [py3porters-devel] [Needs Port] piuparts.debian.org
bernhard at janetzki.eu
Mon Apr 27 17:42:50 UTC 2015
> On 27 Apr 2015, at 17:21, Holger Levsen <holger at layer-acht.org> wrote:
>> Remote: git at github.com:ierror/piuparts.git
>> Branch: bernhard/py3_imports
>> Commit: 9b1d149b8789d6201e66c1d9ab30448753a97296
>> One some files i removed unused ConfigParser / commands imports.
> nice, cherry-picked into the develop branch, thanks.
> BTW, you dont have to give me this verbose info, just the output of "git log
> --oneline" is enough.
> On Sonntag, 19. April 2015, Bernhard Janetzki wrote:
>> Here are three more patches. I ran the test suite against and tested a deb
>> file with piuparts.py
>> # bernhard/py3_print - made print calls py3 ready
>> Commits: 14f361b096b8b942b94acafa3df5a42d8ccd7172
>> # bernhard/py3_urllib - made urllib import statements py3 ready
>> Commits: d34eccc6237ff3d6bb212cc172bf6d5c823144fa
> thanks, both cherry-picked.
>> # bernhard/tox - use to for the unit testes - ATM only for py27, i’ll add
>> py34 target if all test pass under it Remote:
>> git at github.com:ierror/piuparts.git
>> Branch: bernhard/tox
>> Commits: 77cbd7a0a7e8a62e5b30826ef7c02ceeb9587ced
> two questions:
> - are all those additions to .gitignore really needed for this commit?
I don’t know what’s the correct way here. There are some ignores related to my dev env (IDE project files) - I’ll move them to my global .gitignore
Thanks for pointing that out.
> - why did you disable the nosetests in the Makefile, ah, because they are run
> by tox.
> and here the tox tests are disabled for python34, so I think I'll wait merging
> these until all test also pass under 34? Wait, debian/control says nothing
> about python34 anyway, so taking these should be harmless for the Debian
> package, no?
They are harmless, nevertheless i have to rewrite this commit.
ATM i’m using a test requirements file (tests/requirements.txt) to install the dependencies on an tox run. The dependencies are installed via pypi - what’s not the right way for a debian package, i guess :) To make testing more comfortable we could add a “aptitude install python-nose python-mox3 ...” command within the "make check” call to have all test dependencies ready? If we enable py34 testing we simply can add python3-mox3 and so on to the install command.
What’s your opinion here?
fpr: 90E7 F356 3F9D 6595 616F 9068 DE13 283B 99C3 C059
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
More information about the Piuparts-devel