[Piuparts-devel] Bug#825487: Bug#825487: Bug#825487: Patch

[Holger Levsen]

Hi Sean,

thanks for your patience and for summarizing your questions.

On Sat, Oct 01, 2016 at 05:00:59PM -0700, Sean Whitton wrote:
> Since the questions I asked were quite fundamental to the patch, I'd
> prefer to ask some feedback on them before I dive into the code again.
> 
> 1. --allow-downgrades seems to be necessary when using the `apt-get
> install ./foo.deb` invocation, if foo.deb is already installed with the
> same version.  Otherwise, the re-install fails.  That breaks piuparts'
> standard reinstall test.  (As you say, it is not required with `apt-get
> install foo` -- not sure if that is deliberate.)
> 
> I'll verify that apt has not changed its behaviour since the time I
> prepared my first patch, but if the --allow-downgrades is still
> required, do you still object to it?  If so, this bug is wontfix.

Seems fine (and actually required to use --allow-downgrades here).

> 2. Andreas said that dropping the call to list_installed_files "breaks
> some options that are not frequently used".  What could those options
> be?  I thought that list_installed_files should be called once for each
> command that is run.  So when I removed the `dpkg -i` call, I removed
> the call to list_installed_files.  Why is that wrong?

I seem to recall you removed it one to many times.

> (of course, I am going to add a check for the version of apt, and if
> it's old I'll call `dpkg -i` and list_installed_files, but I'm talking
> about the case where apt is new enough and I'm calling `apt-get install
> ./foo.deb`).

If you call "apt-get install" instead of "dpkg -i" you surely will need
to call list_installed_files as well and not remove it?!


Judging by these questions I think the best case of action is that you
rework the patch (if needed) and then point me again to it and then I'll
hopefully just merge it…! ;-)


-- 
cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20161202/aeccfde1/attachment.sig>