[Piuparts-devel] Bug#850524: asciidoc: Migration of conffiles for tests from asciidoc to asciidoc-tests probably unclean (despite being piuparts-clean)

[Axel Beckert]

Package: asciidoc
Version: 8.6.9-4

Dear AsciiDoc Maintainers,

as mentioned in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850305#10 I noticed
that the asciidoc package does seem to contain a lot of files in
/etc/asciidoc/ related to tests (which have been moved to the
asciidoc-tests binary package with 8.6.9-4):

→ dpkg -L asciidoc
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/asciidoc
/usr/share/doc/asciidoc/NEWS.Debian.gz
/usr/share/doc/asciidoc/README.Debian
/usr/share/doc/asciidoc/changelog.Debian.gz
/usr/share/doc/asciidoc/changelog.gz
/usr/share/doc/asciidoc/copyright
/etc/asciidoc/testasciidoc.conf
/etc/asciidoc/data/utf8-examples.txt
/etc/asciidoc/data/utf8-bom-test.txt
/etc/asciidoc/data/testcases.txt
/etc/asciidoc/data/testcases.conf
/etc/asciidoc/data/rcs-id-marker-test.txt
/etc/asciidoc/data/open-block-test.txt
/etc/asciidoc/data/oldtables.txt
/etc/asciidoc/data/lang-uk-test.txt
/etc/asciidoc/data/lang-uk-man-test.txt
/etc/asciidoc/data/lang-ru-test.txt
/etc/asciidoc/data/lang-ru-man-test.txt
/etc/asciidoc/data/lang-ro-test.txt
/etc/asciidoc/data/lang-ro-man-test.txt
/etc/asciidoc/data/lang-pt-BR-test.txt
/etc/asciidoc/data/lang-pt-BR-man-test.txt
/etc/asciidoc/data/lang-nl-test.txt
/etc/asciidoc/data/lang-nl-man-test.txt
/etc/asciidoc/data/lang-it-test.txt
/etc/asciidoc/data/lang-it-man-test.txt
/etc/asciidoc/data/lang-hu-test.txt
/etc/asciidoc/data/lang-hu-man-test.txt
/etc/asciidoc/data/lang-fr-test.txt
/etc/asciidoc/data/lang-fr-man-test.txt
/etc/asciidoc/data/lang-es-test.txt
/etc/asciidoc/data/lang-es-man-test.txt
/etc/asciidoc/data/lang-en-test.txt
/etc/asciidoc/data/lang-en-man-test.txt
/etc/asciidoc/data/lang-de-test.txt
/etc/asciidoc/data/lang-de-man-test.txt
/etc/asciidoc/data/lang-cs-test.txt
/etc/asciidoc/data/lang-cs-man-test.txt
/etc/asciidoc/data/filters-test.txt
/etc/asciidoc/data/deprecated-quotes.txt

But apt-file says something different:

→ apt-file list asciidoc
asciidoc: /usr/share/doc/asciidoc/NEWS.Debian.gz
asciidoc: /usr/share/doc/asciidoc/README.Debian
asciidoc: /usr/share/doc/asciidoc/changelog.Debian.gz
asciidoc: /usr/share/doc/asciidoc/changelog.gz
asciidoc: /usr/share/doc/asciidoc/copyright

Note that I didn't have the package asciidoc-tests installed which
apt-file lists as the package which contains them:

→ apt-file list asciidoc-tests
asciidoc-tests: /etc/asciidoc/data/deprecated-quotes.txt
asciidoc-tests: /etc/asciidoc/data/filters-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-cs-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-cs-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-de-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-de-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-en-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-en-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-es-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-es-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-fr-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-fr-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-hu-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-hu-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-it-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-it-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-nl-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-nl-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-pt-BR-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-pt-BR-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-ro-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-ro-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-ru-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-ru-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-uk-man-test.txt
asciidoc-tests: /etc/asciidoc/data/lang-uk-test.txt
asciidoc-tests: /etc/asciidoc/data/oldtables.txt
asciidoc-tests: /etc/asciidoc/data/open-block-test.txt
asciidoc-tests: /etc/asciidoc/data/rcs-id-marker-test.txt
asciidoc-tests: /etc/asciidoc/data/testcases.conf
asciidoc-tests: /etc/asciidoc/data/testcases.txt
asciidoc-tests: /etc/asciidoc/data/utf8-bom-test.txt
asciidoc-tests: /etc/asciidoc/data/utf8-examples.txt
asciidoc-tests: /etc/asciidoc/testasciidoc.conf
asciidoc-tests: /usr/bin/testasciidoc
asciidoc-tests: /usr/share/doc/asciidoc-tests/NEWS.Debian.gz
asciidoc-tests: /usr/share/doc/asciidoc-tests/changelog.Debian.gz
asciidoc-tests: /usr/share/doc/asciidoc-tests/changelog.gz
asciidoc-tests: /usr/share/doc/asciidoc-tests/copyright
asciidoc-tests: /usr/share/man/man1/testasciidoc.1.gz

So I installed asciidoc-tests to provoke a file installation conflict,
but to my surprise the installation of asciidoc-tests went smooth. And
afterwards everything looks fine as it should be:

→ dpkg -L asciidoc
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/asciidoc
/usr/share/doc/asciidoc/NEWS.Debian.gz
/usr/share/doc/asciidoc/README.Debian
/usr/share/doc/asciidoc/changelog.Debian.gz
/usr/share/doc/asciidoc/changelog.gz
/usr/share/doc/asciidoc/copyright

So this looks like an incomplete handling of moving these files from
asciidoc to asciidoc-tests: They probably should have been removed in
asciidoc's postrm on upgrade. (I though wonder if that could provoke
issues where modifications to these files are not preserved if
asciidoc-tests is installed in the same installation run. But since
there's no dependency from asciidoc to asciidoc-tests, I assume that's
ok-ish.)

Accordingly this issue should trigger upgrade-issues (leftover files
after upgrade) with piuparts. But piuparts didn't seem to notice
anything like that:
https://piuparts.debian.org/jessie2stretch/source/a/asciidoc.html

These files were introduced in 8.6.9-3 (version in Jessie) with
https://anonscm.debian.org/git/pkg-asciidoc/pkg-asciidoc.git/commit/?id=1a592df66b6eee8433ffe47f29eec6b7f5d4fb1e
and hence should show up as an issue from Jessie to Stretch (or Sid) in
piuparts. But they don't according to
https://piuparts.debian.org/jessie2stretch/source/a/asciidoc.html, so
either I'm missing something here or I stumbled upon a piuparts bug.
X-Debbugs-Cc'ing the piuparts developers because of this potential
piuparts issue.

Please raise the severity of this bug to "serious" (as nowadays piuparts
errors are considered RC by the release team) if you can see that issue,
too, and agree with my conclusions despite piuparts actually didn't find
an issue (which may be a bug in piuparts).

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.7.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages asciidoc depends on:
ii  asciidoc-dblatex  8.6.9-4

Versions of packages asciidoc recommends:
ii  asciidoc-doc  8.6.9-4
pn  vim-asciidoc  <none>

asciidoc suggests no packages.

-- Configuration Files:
/etc/asciidoc/dblatex/asciidoc-dblatex.sty changed:
%%
%% This style is derived from the docbook one.
%%
\NeedsTeXFormat{LaTeX2e}
\ProvidesPackage{asciidoc}[2008/06/05 AsciiDoc DocBook Style]
%% Just use the original package and pass the options.
\RequirePackageWithOptions{docbook}
% Sidebar is a boxed minipage that can contain verbatim.
% Changed shadow box to double box.
\renewenvironment{sidebar}[1][0.95\textwidth]{
  \hspace{0mm}\newline%
  \noindent\begin{Sbox}\begin{minipage}{#1}%
  \setlength\parskip{\medskipamount}%
}{
  \end{minipage}\end{Sbox}\doublebox{\TheSbox}%
}
% For DocBook literallayout elements, see `./dblatex/dblatex-readme.txt`.
\usepackage{alltt}
% To preserve simple quotes in the blocs of code
\usepackage{upquote}


-- no debconf information