[Piuparts-devel] Bug#850917: Bug#850917: Please export /var/lib/dpkg/alternatives content after installation

[Michael Stapelberg]

Thanks for the review! Answers inline:

On Sun, Jan 15, 2017 at 10:51 PM, Holger Levsen <holger at layer-acht.org> wrote:
> Hi Michael,
>
> On Wed, Jan 11, 2017 at 11:34:52PM +0100, Michael Stapelberg wrote:
>> Attached you can find a first stab at implementing this feature. I
>> introduced a new protocol message to transfer base64-encoded arbitrary
>> binary data.
>
> the patch looks very nice. thanks for adding all the documentation
> already.
>
>> This can easily be used to transfer other files in the
>> same spirit, should that become necessary in the future (it also seems
>> like the clean thing to do, even if we’re just talking about a single
>> file).
>
> nice!
>
>> The files are then made available at
>> /<section>/aux/<package>_<version>/<filename>, e.g.
>> /sid/aux/libva1_1.7.3-2/alternatives.tar.gz.
>
> fine in principle, except this is part of the three concerns I have
> about the patch:
>
> - "aux" is maybe a bit too short (as a directory name), maybe not :)

I’m happy to change it if you have a specific suggestion. If you
don’t, I propose keeping it: auxiliary is hard to spell (especially
for non-native speakers), and aux is precise enough.

> - the option --auxdir is good, but in the current patches this is not
>   seperated from --record-alternatives-in-auxdir or whatever that option
>   to enable alternatives collection should be called. Not sure about the
>   name for that option but you'll get the idea…

Added an --export-alternatives-aux option.

> - please also add a debian/changelog entry…

Done.

I also changed the slave to clean up after itself and implemented
exporting the before/after versions. Further, I changed to code to
only export tarballs once (instead of twice).

Please consider merging the attached updated patch.

-- 
Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Export-var-lib-dpkg-alternatives-tarball-as-aux-file.patch
Type: text/x-patch
Size: 8019 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20170122/f358fa23/attachment.bin>