[Piuparts-devel] Bug#875605: piuparts: esac missing in post_purge_exception script (develop branch) and yields error

[Boud Roukema]

Source: piuparts
Version: 0.81~201709101403~0.80-7-g42acc540
Severity: normal
Tags: patch upstream

Dear Maintainer,

This inhomog build log: https://piuparts.debian.org/sid/fail/libinhomog0_0.1.6.1-1.log includes
the piupart version:

> 0m0.0s INFO: piuparts version 0.81~201709101403~0.80-7-g42acc540 starting up.

and the piupart error:

> 0m27.8s INFO: Running scripts post_purge
> 0m27.8s DEBUG: Starting command: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'tmp/scripts/post_purge_exceptions']
> 0m27.8s DUMP:
>   tmp/scripts/post_purge_exceptions: 62: tmp/scripts/post_purge_exceptions: Syntax error: end of file unexpected (expecting ";;")
> 0m27.8s ERROR: Command failed (status=2): ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'tmp/scripts/post_purge_exceptions']
>   tmp/scripts/post_purge_exceptions: 62: tmp/scripts/post_purge_exceptions: Syntax error: end of file unexpected (expecting ";;")

The bug can be reproduced with

  ./post_purge_exceptions dummy

where dummy is a file with the five bytes 'dddd\n'.

This looks like it's from a recent modification in the "develop" branch of piuparts:

https://anonscm.debian.org/cgit/piuparts/piuparts.git/tree/custom-scripts/scripts/post_purge_exceptions?h=develop

It seems to me that the problem is a missing "esac\n;;" (earlier than
line 62). I've attached a patch that works for me on a dummy file.


-- System Information:
This is from the build log above:
>   0m20.9s DUMP:
>     Package files:
>      100 /var/lib/dpkg/status
>        release a=now
>      500 http://mirror.bm.debian.org/debian sid/main amd64 Packages
>        release o=Debian,a=unstable,n=sid,l=Debian,c=main,b=amd64
>        origin mirror.bm.debian.org
>     Pinned packages:
>   0m20.9s DEBUG: Command ok: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'apt-cache', 'policy']
>   0m20.9s DEBUG: Starting command: ['chroot', '/srv/piuparts.debian.org/tmp/tmpYXIehL', 'apt-cache', 'policy', 'libinhomog0']
>   0m21.0s DUMP:
>   libinhomog0:
>   Installed: (none)
>   Candidate: 0.1.6.1-1
>   Version table:
>   0.1.6.1-1 500
>   500 http://mirror.bm.debian.org/debian sid/main amd64 Packages