[Piuparts-devel] [Git][debian/piuparts][develop] p: clarify errors from installing objects over existing symlinks

[Holger Levsen]

Holger Levsen pushed to branch develop at Debian / piuparts


Commits:
acc2a678 by Andreas Beckmann at 2018-11-28T09:49:31Z
p: clarify errors from installing objects over existing symlinks

objects can be files, directories, ...

Signed-off-by: Andreas Beckmann <anbe at debian.org>
Signed-off-by: Holger Levsen <holger at layer-acht.org>

- - - - -


4 changed files:

- debian/changelog
- known_problems/installs_over_symlink_error.conf
- known_problems/installs_over_symlink_issue.conf
- piuparts.py


Changes:

=====================================
debian/changelog
=====================================
@@ -1,5 +1,6 @@
 piuparts (0.95) UNRELEASED; urgency=medium
 
+  [ Holger Levsen ]
   * piuparts.py: add /var/lib/debian-security-support/ to self.ignored_files.
     (Closes: #749317)
   * WIP: reduce number of mails per day, from 34 down to 18, see #912591.
@@ -12,6 +13,9 @@ piuparts (0.95) UNRELEASED; urgency=medium
     - lib/write_log.sh: new helper to publish logs in htdocs/logs.
     - piuparts-report.py: add navigation link to https://piuparts.d.o/logs/
 
+  [ Andreas Beckmann ]
+  * Clarify errors from installing objects over existing symlinks.
+
  -- Holger Levsen <holger at debian.org>  Thu, 08 Nov 2018 12:12:21 +0100
 
 piuparts (0.94) unstable; urgency=medium


=====================================
known_problems/installs_over_symlink_error.conf
=====================================
@@ -1,7 +1,7 @@
 #
 # detect packages which have the string "dirname part contains a symlink" in their logs
 #
-PATTERN='silently overwrites files via directory symlinks|dirname part contains a symlink'
+PATTERN='silently overwrites files via directory symlinks|installs objects over existing directory symlinks|dirname part contains a symlink'
 WHERE='fail bugged affected'
 ISSUE=0
 HEADER='Packages that install something over existing symlinks'


=====================================
known_problems/installs_over_symlink_issue.conf
=====================================
@@ -1,7 +1,7 @@
 #
 # detect packages which have the string "dirname part contains a symlink" in their logs
 #
-PATTERN='silently overwrites files via directory symlinks|dirname part contains a symlink'
+PATTERN='silently overwrites files via directory symlinks|installs objects over existing directory symlinks|dirname part contains a symlink'
 WHERE='pass'
 ISSUE=1
 HEADER='Packages that install something over existing symlinks'


=====================================
piuparts.py
=====================================
@@ -1489,13 +1489,15 @@ class Chroot:
                     bad.append("  %s -> %s" % (link, target))
         if bad:
             if overwrites:
-                logging.error("FAIL: silently overwrites files via directory symlinks:\n" +
-                              indent_string("\n".join(bad)))
+                msg = "FAIL: silently overwrites files via directory symlinks:\n"
             else:
-                logging.info("dirname part contains a symlink:\n" +
-                             indent_string("\n".join(bad)))
+                msg = "installs objects over existing directory symlinks:\n"
+            msg += indent_string("\n".join(bad))
             if not settings.warn_on_install_over_symlink:
+                logging.error(msg)
                 panic()
+            else:
+                logging.info(msg)
 
     def remove_packages(self, packages, ignore_errors=False):
         """Remove packages in a chroot."""



View it on GitLab: https://salsa.debian.org/debian/piuparts/commit/acc2a67884faaa401cfc61b1e4693705cd20ac89

-- 
View it on GitLab: https://salsa.debian.org/debian/piuparts/commit/acc2a67884faaa401cfc61b1e4693705cd20ac89
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/piuparts-devel/attachments/20181128/d4273a44/attachment-0001.html>