[Piuparts-devel] Bug#911334: Create /dev/ptmx like debootstrap does

[Mathieu Parent]

Package: piuparts
Version: 0.92
Tag: patch

Hello,

When using piuparts on a chroot without /dev/ptmx [noptmx],
scripts/pre_remove_50_find_bad_permissions fails with:

    ERROR: BAD PERMISSIONS
    crw-rw-rw-. 1 root root 5, 2 Oct 16 03:49 /dev/ptmx

In this case, piuparts does something like this:

    touch /dev/ptmx
    mount -o bind /dev/pts/ptmx /dev/ptmx

The kernel doc [devpts.txt] recommends instead:

    mknod /dev/ptmx c 5 2

And this is what debootstrap does [debootstrap].

I propose to map the piuparts behavior with debootstrap's.

My proposed change is at
https://salsa.debian.org/debian/piuparts/merge_requests/2


Regards
-- 
Mathieu Parent

[noptmx]: This is the case when chroot comes from the debian:unstable
Docker image
[devpts.txt]: https://www.kernel.org/doc/Documentation/filesystems/devpts.txt
[debootstrap] https://salsa.debian.org/installer-team/debootstrap/blob/6f3f6f8b76e2d1a24ddbf05f065439412c3b81a1/functions#L1263-1268,
introduced by https://salsa.debian.org/installer-team/debootstrap/commit/c997b80c064c6c1d36ec69da1850722f795f43e4