[Piuparts-devel] Bug#911334: Bug#911334: Create /dev/ptmx like debootstrap does

[Mathieu Parent]

Le lun. 29 oct. 2018 à 17:25, Holger Levsen <holger at layer-acht.org> a écrit :
>
> Hi Mathieu,

Hi Holger,

> On Sun, Oct 28, 2018 at 09:43:50PM +0100, Mathieu Parent wrote:
> > Thanks. I've done the findutils bug (#912180, with even a patch) and
> > I've updated the MR (see also the attached patch).
> >
> > If the commit message is too verbose, you can amend it.
>
> that's all cool, now, thanks a lot for your patience & for following up
> nicely!

This was hard work for me (I even wrote a minimum C program), but I've
learnt more things.

> I've merged your work now and will deploy it to piuparts.d.o after
> sending this email. Just one question:

Thanks

> > +  [ Mathieu Parent ]
> > +  * piuparts.py: Use mknod instead of touch to create missing /dev/ptmx
> > +    mountpoint, working around findutils bug #912180 (Closes: #911334)
>
> does that mean, that once #912180 has been fixed, we can and should
> revert a99ecade (=your commit) ?

I don't know. Maybe the proper behavior of piuparts should match
debootstrap's. This willwork with any dist given kernel is >= 3.16.

The kernel doc, says either mknod, or symlink or bindmount. piuparts
now (after this merge) does mknod+bindmount.

https://www.kernel.org/doc/Documentation/filesystems/devpts.txt

> If not, I suppose the changelog entry should be clarified...

Don't know.

-- 
Mathieu