[Piuparts-devel] First step to Python 3

[Holger Levsen]

On Tue, Jan 15, 2019 at 01:53:16PM -0200, Herbert Fortes wrote:
> > I guess xmlto will need to be ported to python3 then?
> I am wrong. asciidoc*[0] seems to be the problem:

I think there's asciidoctor which is (more or less?) a drop in
replacement for asciidoc, but using python3.

> > Thanks for all your work on this! Really very much appreciated!
> Good! I am really enjoying it. There is more work to do. Like
> a review/cleanning:

yay!

> ./master-bin/detect_well_known_errors.py:
>         [os.mkdir(x) for x in workdirs if not os.path.exists(x)]
> 
> It is to make dirs only. It can be '()' instead of '[]', I guess.
> 
> piuparts.py
>  for vfile in files[:]:
> 
> The '[:]'.
> 
> ./piuparts-master-backend.py:            if len(parts) > 0:
> 
> 
> Maybe an 'import' that is not used anymore. Have to check these.
> flake8, isort.

please, by all means, do create seperate patch/pull requests for these
issues. the smaller the issue and the better the commit message, the
easier to merge!


-- 
tschüß,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/piuparts-devel/attachments/20190125/a3dd0874/attachment.sig>