[Piuparts-devel] Bug#1068312: piuparts: Error when Adding 'local diversion of /bin/sync to /bin/sync.distrib.usr-is-merged' (bullseye)

[Helmut Grohne]

Control: tags -1 + confirmd patch
Control: forwarded -1 https://salsa.debian.org/debian/piuparts/-/merge_requests/56

On Wed, Apr 03, 2024 at 01:40:28PM +0200, Fab Stz wrote:
> I have a CI job on salsa running piuparts with bullseye.
> Recently it started failing with this error:
> 
> 0m4.3s DUMP:
>   Enabling dpkg --force-unsafe-io.
>   Adding 'local diversion of /bin/sync to /bin/sync.distrib.usr-is-merged'
>   ln: failed to create symbolic link '/bin/sync': File exists
> 0m4.3s ERROR: Command failed (status=1): ['chroot', '/tmp/tmpoj1y68a1',
> 'eatmydata', 'tmp/scripts/post_setup_force-unsafe-io']
>   Enabling dpkg --force-unsafe-io.
>   Adding 'local diversion of /bin/sync to /bin/sync.distrib.usr-is-merged'
>   ln: failed to create symbolic link '/bin/sync': File exists
> 
> 
> Maybe this is somehow related to the latest changes in 1.4.1 mentioned as 
> "also fix /bin/sync diversion for bookworm"?

I confirm the problem and understand the failure. Mea culpa.

When I adapted the code for bookworm (which is /usr-merged, but has
/bin/sync), I failed to notice that I also conditionalized the moving
code, so the unmerged-/usr path would now divert with --no-rename and
not move /bin/sync either. That makes ln unhappy as we can see.

I've created a merge request to address this regression and am sorry for
having broken piuparts so many times.

Helmut