Bug#879594: gnome-orca: should update caret position while speaking entire document in firefox

[Samuel Thibault]

Package: gnome-orca
Version: 3.26.0-1
Severity: normal
Tags: a11y patch
Owner: bugs at hypra.fr
User: bugs at hypra.fr
Usertags: hypra
Forwarded: https://bugzilla.gnome.org/show_bug.cgi?id=789340

As forwarded to upstream, reported here for tracking the issue

“
With a webpage opened in firefox, the KP_Add shortcut allows to "speak entire document", just like in other application. One difference, however, is that in other applications, during the speaking of the whole document, the cursor position is updated regularly, to show the progress of the speak, which is convenient for users, but in Firefox this does not happen, the cursor position is only updated at the end of the speak (at speak stop position).

I don't know whether that was intentional, but users have expressed they would like the feature to be enabled in firefox too.

The attached patch fixes this by calling setCaretOffset instead of setCaretContext in __sayAllProgressCallback.
”

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'stable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gnome-orca depends on:
ii  gir1.2-glib-2.0            1.54.1-1
ii  gir1.2-gtk-3.0             3.22.24-2
ii  gir1.2-pango-1.0           1.40.12-1
ii  gir1.2-wnck-3.0            3.24.1-1
ii  gsettings-desktop-schemas  3.24.1-1
ii  python3                    3.5.3-3
ii  python3-brlapi             5.5-3
ii  python3-cairo              1.10.0+dfsg-5+b3
ii  python3-gi                 3.24.1-3
ii  python3-louis              3.3.0-1
ii  python3-pyatspi            2.24.0+dfsg-1
ii  python3-speechd            0.8.7-1
ii  speech-dispatcher          0.8.7-1

Versions of packages gnome-orca recommends:
ii  libgail-common  2.24.31-2
ii  xbrlapi         5.5-3

gnome-orca suggests no packages.

-- no debconf information

-- 
Samuel
Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu
maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a
plein d'humains et de primates, et ça devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-
-------------- next part --------------
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index eeb39c588..61bdde27f 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -710,7 +710,7 @@ class Script(default.Script):
             return
 
         orca.setLocusOfFocus(None, context.obj, notifyScript=False)
-        self.utilities.setCaretContext(context.obj, context.currentOffset)
+        self.utilities.setCaretOffset(context.obj, context.currentOffset)
 
     def inFocusMode(self):
         """ Returns True if we're in focus mode."""