Bug#868132: Needless build dependency on kdelibs5-dev

[Alexander Volkov]

03.12.2017 18:09, Samuel Thibault пишет:
> Well, the build does fail ATM :)
>
> CMake Error at CMakeLists.txt:11 (include):
>    include could not find load file:
>
>      KDE4Defaults
>
> There are indeed kde things in CMakeLists files, I'm not sure I really
> want to spend time on crippling them just for avoiding the kdelibs5-dev,
> unless there is a compelling reason which wasn't reported?
Ah, sorry, nokde patch is really not enough.
I maintain this package in AstraLinux and we don't support KDE4.
Here is our extended nokde patch.
Feel free to close this bug if it's not suitable.

BR,
Alexander.
-------------- next part --------------
--- a/src/bridge.cpp
+++ b/src/bridge.cpp
@@ -21,7 +21,7 @@
 #include "bridge.h"
 
 #include <qaccessible2.h>
-#include <kcomponentdata.h>
+//#include <kcomponentdata.h>
 
 #include "atspiadaptor.h"
 
@@ -54,7 +54,7 @@
     }
 
     // This gives us translations
-    KComponentData componentData("qtatspi_qt");
+    //KComponentData componentData("qtatspi_qt");
 
     qSpiInitializeStructTypes();
     qSpiInitializeConstantMappings();
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -28,9 +28,9 @@
 # headers are needed from there for the types used in dbus
 include_directories(${CMAKE_SOURCE_DIR}/src)
 
-kde4_add_library(qspiaccessiblebridge SHARED ${qspiaccessiblebridge_SRCS})
+add_library(qspiaccessiblebridge SHARED ${qspiaccessiblebridge_SRCS})
 
-target_link_libraries(qspiaccessiblebridge ${QT_QTCORE_LIBRARY} ${QT_QTGUI_LIBRARY} ${QT_QTDBUS_LIBRARY} ${X11_X11_LIB} ${KDE4_KDECORE_LIBS})
+target_link_libraries(qspiaccessiblebridge ${QT_QTCORE_LIBRARY} ${QT_QTGUI_LIBRARY} ${QT_QTDBUS_LIBRARY} ${X11_X11_LIB})
 
 install(TARGETS qspiaccessiblebridge DESTINATION ${QTATSPI_QT_PLUGIN_INSTALL_DIR}/accessiblebridge/)
 
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,10 +7,8 @@
 #option(KDE4_BUILD_TESTS  "Build the tests" ON)
 
 find_package(Qt4 4.8 REQUIRED)
-find_package(KDE4)
-include(KDE4Defaults)
 
-include_directories(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} ${QT4_INCLUDES}  ${QT_INCLUDE_DIR} ${QT_QT_INCLUDE_DIR} ${QT_QTDBUS_INCLUDE_DIR} ${QT_QTCORE_INCLUDE_DIR} ${QT_QTGUI_INCLUDE_DIR} ${KDE4_INCLUDES})
+include_directories(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} ${QT4_INCLUDES}  ${QT_INCLUDE_DIR} ${QT_QT_INCLUDE_DIR} ${QT_QTDBUS_INCLUDE_DIR} ${QT_QTCORE_INCLUDE_DIR} ${QT_QTGUI_INCLUDE_DIR})
 
 # Require libatspi2-core headers for building:
 include(FindPkgConfig)
@@ -23,6 +21,4 @@
 
 add_subdirectory(src)
 add_subdirectory(translations)
-add_subdirectory(tests)
-add_subdirectory(examples)