Bug#895533: flite: don't run dh_auto_clean if configure has not run yet

James Cowgill jcowgill at debian.org
Thu Apr 12 10:16:06 UTC 2018


Source: flite
Version: 2.1-release-1
Severity: normal
Tags: patch

Hi,

flite FTBFS on riscv64:
https://buildd.debian.org/status/fetch.php?pkg=flite&arch=riscv64&ver=2.1-release-1&stamp=1522978424&raw=0

This happens because the main Makefile will always run configure if it
has not run yet and this will fail on new architectures if config.guess
has not been updated yet.

To resolve this, I think flite should only run dh_auto_clean if
config.log already exists.

After fixing this, I found that the clean target fails when run after
the build has completed with this error:
>    dh_clean
> rm: cannot remove './doc/html': Is a directory

dh_clean will refuse to remove directories in debian/clean unless they
end with a trailing slash.

I've attached a patch which fixes both of these issues.

Thanks,
James
-------------- next part --------------
diff -Nru flite-2.1-release/debian/clean flite-2.1-release/debian/clean
--- flite-2.1-release/debian/clean	2018-01-03 20:07:27.000000000 +0000
+++ flite-2.1-release/debian/clean	2018-04-12 10:39:34.000000000 +0100
@@ -13,7 +13,7 @@
 doc/flite.toc
 doc/flite.tp
 doc/flite.vr
-doc/html
+doc/html/
 include/flite_version.h
 lib/
 main/flite_voice_list.c
diff -Nru flite-2.1-release/debian/rules flite-2.1-release/debian/rules
--- flite-2.1-release/debian/rules	2018-01-03 20:44:36.000000000 +0000
+++ flite-2.1-release/debian/rules	2018-04-12 10:39:34.000000000 +0100
@@ -17,6 +17,9 @@
 AUDIO=oss
 endif
 
+override_dh_auto_clean:
+	[ ! -f config.log ] || dh_auto_clean
+
 override_dh_auto_configure:
 	dh_auto_configure -- --with-audio=$(AUDIO) \
 		--with-vox=cmu_us_kal16 --enable-shared
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-a11y-devel/attachments/20180412/42e2a285/attachment.sig>


More information about the Pkg-a11y-devel mailing list