Bug#946235: atk1.0: please make autopkgtests cross-test-friendly

Simon McVittie smcv at debian.org
Fri Dec 6 09:19:30 GMT 2019

On Thu, 05 Dec 2019 at 15:18:40 -0800, Steve Langasek wrote:
> This requires changes to some tests so that they are cross-aware and can do
> the right thing.

Thanks for this patch. I'm assuming this is going to be the first of many
build smoke-tests that will need similar changes when the autopkgtest
change lands, so I'm being extra-careful when reviewing it, to try to
get the clearest possible patches for other packages.

> +if [ -n "$DEB_HOST_MULTIARCH" ]; then
> +    export PKG_CONFIG_PATH="/usr/lib/$DEB_HOST_MULTIARCH/pkgconfig"
> +fi
> +${PREFIX}gcc -Wall -Werror -o atk1.0-dev_test atk1.0-dev_test.c `pkg-config --cflags --libs atk`

I think it would be both more concise and more realistic to use
${PREFIX}pkg-config instead of setting PKG_CONFIG_PATH, and rely on the
multiarch symlink to /usr/share/pkg-config-crosswrapper for the mechanics
of finding the right library? That matches what will actually happen when
cross-compiling with dpkg, if I understand correctly (and it's actually
PKG_CONFIG_LIBDIR that gets set in the cross-wrapper).

Perhaps it would be clearer to name the variable CROSS_COMPILE instead of
PREFIX, to avoid it being mixed up with other concepts also named prefix,
like the one that is normally /usr? `make CROSS_COMPILE=i686-linux-gnu-`
and `CC=${CROSS_COMPILE}gcc` is the convention used for the equivalent
variable in for example Linux, Busybox and OpenSSL, so it should be
reasonably familiar.


More information about the Pkg-a11y-devel mailing list