Bug#946361: at-spi2-core: Please make autopkgtests cross-test-friendly

[Steve Langasek]

Package: at-spi2-core
Version: 2.34.0-3
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

The at-spi2-core tests currently fail in this environment, because they have
a dependency on gedit, which tries to pull in the i386 version of gedit
instead of the amd64 version and this is not cross-installable.  However it
doesn't appear that there is anything in the test case that requires gedit
to be of the same architecture (at-spi2-core communicates with gedit over a
bus, not in process memory), so we should fix the test so that the amd64
version of gedit can be used.

One way to do this would be a multiarch annotation on the gedit package
itself.  It would not be correct to mark gedit Multi-Arch: foreign, because
there are reverse-dependencies of gedit that are plugins; so gedit would at
most be Multi-Arch: allowed.  However, in that case at-spi2-core would still
need to change in that case to specify a test dep on gedit:any instead of
gedit; so it's simpler to just change at-spi2-core to depend on gedit:native
as in the attached patch.

Support for cross-testing in autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru at-spi2-core-2.34.0/debian/tests/control at-spi2-core-2.34.0/debian/tests/control
--- at-spi2-core-2.34.0/debian/tests/control	2019-09-29 05:38:10.000000000 -0700
+++ at-spi2-core-2.34.0/debian/tests/control	2019-12-07 12:21:52.000000000 -0800
@@ -1,2 +1,2 @@
 Tests: gedit dbind
-Depends: libatspi2.0-dev, build-essential, xauth, xvfb, dbus, at-spi2-core, gedit
+Depends: libatspi2.0-dev, build-essential, xauth, xvfb, dbus, at-spi2-core, gedit:native