Bug#997158: ebook-speaker: FTBFS: ebook-speaker.c:254:52: error: format not a string literal and no format arguments [-Werror=format-security]

Lucas Nussbaum lucas at debian.org
Sat Oct 23 20:05:51 BST 2021


Source: ebook-speaker
Version: 6.2.0-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -D LOCALEDIR=\"/usr/share/locale\" -D EBOOK_SPEAKER -D PROGRAMNAME_LOCALEDIR=\"\" -I /usr/include/libxml2/ -Wall -Wextra -Wconversion -g -Wunused-function -Wuninitialized -Winit-self -Wlogical-op -Wpedantic -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -I/usr/include/libxml2 -c -o opf.o opf.c
> ebook-speaker.c: In function ‘get_next_phrase’:
> ebook-speaker.c:254:52: error: format not a string literal and no format arguments [-Werror=format-security]
>   254 |             mvwprintw (misc->screenwin, 22, 0, misc->str);
>       |                                                ~~~~^~~~~
> ebook-speaker.c: In function ‘view_screen’:
> ebook-speaker.c:728:57: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘long int’ [-Wformat=]
>   728 |          mvwprintw (misc->screenwin, daisy[i].y, 75, "%5d", l);
>       |                                                       ~~^   ~
>       |                                                         |   |
>       |                                                         int long int
>       |                                                       %5ld
> ebook-speaker.c: In function ‘browse’:
> ebook-speaker.c:1711:47: error: format not a string literal and no format arguments [-Werror=format-security]
>  1711 |          mvwprintw (misc->titlewin, 0, 0, misc->copyright);
>       |                                           ~~~~^~~~~~~~~~~
> ebook-speaker.c: In function ‘play_epub’:
> ebook-speaker.c:2574:41: error: format not a string literal and no format arguments [-Werror=format-security]
>  2574 |    mvwprintw (misc->titlewin, 0, 0, misc->copyright);
>       |                                     ~~~~^~~~~~~~~~~
> ebook-speaker.c: In function ‘clear_tmp_dir’:
> ebook-speaker.c:28:7: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    28 |       system (misc->cmd);
>       |       ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c: In function ‘quit_eBook_speaker’:
> ebook-speaker.c:36:4: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    36 |    system ("reset");
>       |    ^~~~~~~~~~~~~~~~
> ebook-speaker.c: In function ‘start_playing’:
> ebook-speaker.c:148:4: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   148 |    system (misc->tts[misc->tts_no]);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ebook-speaker.c: In function ‘browse’:
> ebook-speaker.c:1614:13: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  1614 |             system (misc->cmd);
>       |             ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c:1667:10: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  1667 |          system (misc->cmd);
>       |          ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c:1849:13: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  1849 |             system (misc->cmd);
>       |             ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c:1869:13: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  1869 |             system (misc->cmd);
>       |             ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c: In function ‘store_item_as_WAV_file’:
> ebook-speaker.c:2276:10: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  2276 |          system (misc->tts[misc->tts_no]);
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ebook-speaker.c:2281:10: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  2281 |          system (misc->cmd);
>       |          ^~~~~~~~~~~~~~~~~~
> ebook-speaker.c:2290:13: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  2290 |             write (w, buf, (size_t) in);
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ebook-speaker.c:2308:4: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>  2308 |    system (misc->cmd);
>       |    ^~~~~~~~~~~~~~~~~~
> In file included from /usr/include/string.h:519,
>                  from daisy.h:24,
>                  from ebook-speaker.c:20:
> In function ‘strncpy’,
>     inlined from ‘remove_double_tts_entries’ at ebook-speaker.c:71:10:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:91:10: warning: ‘__builtin_strncpy’ output may be truncated copying 512 bytes from a string of length 6143 [-Wstringop-truncation]
>    91 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -D LOCALEDIR=\"/usr/share/locale\" -D EBOOK_SPEAKER -D PROGRAMNAME_LOCALEDIR=\"\" -I /usr/include/libxml2/ -Wall -Wextra -Wconversion -g -Wunused-function -Wuninitialized -Winit-self -Wlogical-op -Wpedantic -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -I/usr/include/libxml2 -c -o alsa_ctl.o alsa_ctl.c
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -D LOCALEDIR=\"/usr/share/locale\" -D EBOOK_SPEAKER -D PROGRAMNAME_LOCALEDIR=\"\" -I /usr/include/libxml2/ -Wall -Wextra -Wconversion -g -Wunused-function -Wuninitialized -Winit-self -Wlogical-op -Wpedantic -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -I/usr/include/libxml2 -c -o pactl/src/core-util.o pactl/src/core-util.c
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -D LOCALEDIR=\"/usr/share/locale\" -D EBOOK_SPEAKER -D PROGRAMNAME_LOCALEDIR=\"\" -I /usr/include/libxml2/ -Wall -Wextra -Wconversion -g -Wunused-function -Wuninitialized -Winit-self -Wlogical-op -Wpedantic -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -I/usr/include/libxml2 -c -o pactl/src/strbuf.o pactl/src/strbuf.c
> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -D LOCALEDIR=\"/usr/share/locale\" -D EBOOK_SPEAKER -D PROGRAMNAME_LOCALEDIR=\"\" -I /usr/include/libxml2/ -Wall -Wextra -Wconversion -g -Wunused-function -Wuninitialized -Winit-self -Wlogical-op -Wpedantic -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -I/usr/include/libxml2 -c -o pactl/src/pactl.o pactl/src/pactl.c
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:441: ebook-speaker.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/ebook-speaker_6.2.0-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.



More information about the Pkg-a11y-devel mailing list