Bug#1030264: bullseye-pu: package at-spi2-core/2.38.0-4+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian.org at packages.debian.org
Usertags: pu
X-Debbugs-Cc: at-spi2-core at packages.debian.org
Control: affects -1 + src:at-spi2-core

[ Reason ]
stable is affected by bug #890833: under some conditions, the
at-spi2-core accessibility daemons don't manage to quit, and thus
on system shutdown, systemd stays stuck for 90s until giving up and
hard-killing it.

The exact conditions have not been determined, but anyway since there is
no state to save etc., it's fine with just killing it early, rather than
annoying users.

[ Impact ]
They may encounter a 90s delay on shutting down their computer.

[ Tests ]
As the conditions are rare, we couldn't test it.

[ Risks ]
The code is very trivial, it just sets a timeout.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
It just adds a TimeoutStopSec to the systemd unit. It sets it to 5s,
just like similar widgets of the gnome desktop.
-------------- next part --------------
diff -Nru at-spi2-core-2.38.0/debian/changelog at-spi2-core-2.38.0/debian/changelog
--- at-spi2-core-2.38.0/debian/changelog	2021-04-22 13:10:24.000000000 +0200
+++ at-spi2-core-2.38.0/debian/changelog	2023-01-25 23:30:27.000000000 +0100
@@ -1,3 +1,9 @@
+at-spi2-core (2.38.0-4+deb11u1) bullseye; urgency=medium
+
+  * patches/timeoutstop: Set stop timeout to 5s (Closes: #890833).
+
+ -- Samuel Thibault <sthibault at debian.org>  Wed, 25 Jan 2023 23:30:27 +0100
+
 at-spi2-core (2.38.0-4) unstable; urgency=medium
 
   * Re-upload to get arch:all built on buildd.
diff -Nru at-spi2-core-2.38.0/debian/patches/series at-spi2-core-2.38.0/debian/patches/series
--- at-spi2-core-2.38.0/debian/patches/series	2021-04-22 00:09:27.000000000 +0200
+++ at-spi2-core-2.38.0/debian/patches/series	2023-01-25 23:30:27.000000000 +0100
@@ -3,3 +3,4 @@
 test_disable_teamspaces
 tests
 double-free
+timeoutstop
diff -Nru at-spi2-core-2.38.0/debian/patches/timeoutstop at-spi2-core-2.38.0/debian/patches/timeoutstop
--- at-spi2-core-2.38.0/debian/patches/timeoutstop	1970-01-01 01:00:00.000000000 +0100
+++ at-spi2-core-2.38.0/debian/patches/timeoutstop	2023-01-25 23:30:27.000000000 +0100
@@ -0,0 +1,27 @@
+commit 145f9c53ca9ed73d0edb39abac12141cd40a2526
+Author: Samuel Thibault <samuel.thibault at ens-lyon.org>
+Date:   Wed Jan 25 20:07:12 2023 +0100
+
+    at-spi-dbus-bus service: set stop timeout to 5s
+    
+    As reported on
+    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890833
+    
+    sometimes the at-spi bus may hang, and system shutdown then gets stuck.
+    We'd better avoid hanging the whole system shutdown just for this, and
+    just wait for 5s, like many other gnome user service pieces.
+    
+    Of course, at-spi2-core shouldn't be getting stuck, but better avoid
+    hurting people, which makes them tend to just disable accessibility...
+
+---
+ bus/at-spi-dbus-bus.service.in |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/bus/at-spi-dbus-bus.service.in
++++ b/bus/at-spi-dbus-bus.service.in
+@@ -5,3 +5,4 @@ Description=Accessibility services bus
+ Type=dbus
+ BusName=org.a11y.Bus
+ ExecStart=@libexecdir@/at-spi-bus-launcher
++TimeoutStopSec=5