Bug#1033996: unblock: brltty/6.5-7
Samuel Thibault
sthibault at debian.org
Thu Apr 6 00:59:45 BST 2023
Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock
X-Debbugs-Cc: brltty at packages.debian.org
Control: affects -1 + src:brltty
Hello,
I have uploaded brltty/6.5-7 to unstable, to make it hopefully included
in bookworm.
[ Reason ]
It was reported on
http://brltty.app/pipermail/brltty/2023-March/019836.html
that cursor routing is not working at all any more in X, because of a
crash in the routing process that 6.5-7 fixes.
[ Impact ]
Cursor routing is the way for blind users to be very efficient. Just
like we can click with the mouse wherever we want in some text to bring
the cursor there, when a blind user is reading some text they can press
a little button above the letter to bring the cursor there. Currently
the cursor doesn't move at all, and thus blind users have lost their way
to be very efficient at editing text.
The problem only affects X, not the Linux console, but more and more
blind users have to migrate to X environments since java-script-enabled
websites can nowaday only be browsed with e.g. firefox.
[ Tests ]
This was tested manually.
[ Risks ]
The code is very trivial: just check for the pointer before freeing the
underlying resource.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
[ Other info ]
I also included a small pending d-i translation.
unblock brltty/6.5-7
-------------- next part --------------
diff -Nru brltty-6.5/debian/changelog brltty-6.5/debian/changelog
--- brltty-6.5/debian/changelog 2022-12-06 22:25:48.000000000 +0100
+++ brltty-6.5/debian/changelog 2023-04-06 01:27:28.000000000 +0200
@@ -1,3 +1,13 @@
+brltty (6.5-7) unstable; urgency=medium
+
+ [ Remus-Gabriel Chelu ]
+ * po/ro.po: Add Romanian debconf translation (Closes: Bug#1031150).
+
+ [ Samuel Thibault ]
+ * patches/atspi2-routing-crash.patch: Fix crash on cursor routing call.
+
+ -- Samuel Thibault <sthibault at debian.org> Thu, 06 Apr 2023 01:27:28 +0200
+
brltty (6.5-6) unstable; urgency=medium
* initramfs/hooks/brltty.in: Copy over brltty preferences into initramfs.
diff -Nru brltty-6.5/debian/patches/atspi2-routing-crash.patch brltty-6.5/debian/patches/atspi2-routing-crash.patch
--- brltty-6.5/debian/patches/atspi2-routing-crash.patch 1970-01-01 01:00:00.000000000 +0100
+++ brltty-6.5/debian/patches/atspi2-routing-crash.patch 2023-04-06 01:26:36.000000000 +0200
@@ -0,0 +1,40 @@
+commit 1d7515229f4283b2b6c1a74135be3eae2d9892cd
+Author: Samuel Thibault <samuel.thibault at ens-lyon.org>
+Date: Thu Apr 6 01:23:37 2023 +0200
+
+ AtSpi2: Fix crash on routing request
+
+ We would otherwise get, here with ubsan:
+
+ brltty: report listener already registered: 5: a2CoreSelUpdated
+ UndefinedBehaviorSanitizer:DEADLYSIGNAL
+ ==2087615==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x56356b124850 bp 0x000000000000 sp 0x7fcc4d9fdbd8 T2087615)
+ ==2087615==The signal is caused by a READ memory access.
+ ==2087615==Hint: address points to the zero page.
+ #0 0x56356b124850 in unregisterReportListener /home/samy/brl/mielke-svn/brltty/Programs/./report.c:208:22
+ #1 0x7fcc5233f0ab in destruct_AtSpi2Screen /home/samy/brl/mielke-svn/brltty/Drivers/Screen/AtSpi2/./a2_screen.c:1574:5
+ #2 0x56356b15304d in destructRoutingScreen /home/samy/brl/mielke-svn/brltty/Programs/./scr.c:255:3
+ #3 0x56356b1542e9 in startRoutingProcess /home/samy/brl/mielke-svn/brltty/Programs/./routing.c:498:9
+ #4 0x56356b1542e9 in runRoutingThread /home/samy/brl/mielke-svn/brltty/Programs/./routing.c:543:17
+ #5 0x56356b11f574 in runThreadFunction /home/samy/brl/mielke-svn/brltty/Programs/./thread.c:151:33
+ #6 0x56356b11f857 in runThread /home/samy/brl/mielke-svn/brltty/Programs/./thread.c:46:18
+ #7 0x7fcc4f9c8fd3 in start_thread nptl/./nptl/pthread_create.c:442:8
+ #8 0x7fcc4fa4966b in clone3 misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
+
+diff --git a/Drivers/Screen/AtSpi2/a2_screen.c b/Drivers/Screen/AtSpi2/a2_screen.c
+index d60a91c68..9d5ca1d23 100644
+--- a/Drivers/Screen/AtSpi2/a2_screen.c
++++ b/Drivers/Screen/AtSpi2/a2_screen.c
+@@ -1571,8 +1571,10 @@ destruct_AtSpi2Screen (void) {
+ brlttyDisableInterrupt();
+ #ifdef HAVE_PKG_X11
+ if (dpy) {
+- unregisterReportListener(coreSelUpdatedListener);
+- coreSelUpdatedListener = NULL;
++ if (coreSelUpdatedListener) {
++ unregisterReportListener(coreSelUpdatedListener);
++ coreSelUpdatedListener = NULL;
++ }
+ if (a2XWatch) {
+ asyncCancelRequest(a2XWatch);
+ a2XWatch = NULL;
diff -Nru brltty-6.5/debian/patches/series brltty-6.5/debian/patches/series
--- brltty-6.5/debian/patches/series 2022-06-18 09:16:48.000000000 +0200
+++ brltty-6.5/debian/patches/series 2023-04-06 01:26:36.000000000 +0200
@@ -2,3 +2,4 @@
40-no-update-pot.patch
41-java-bytecode-compat.patch
disable-synth-callback.patch
+atspi2-routing-crash.patch
diff -Nru brltty-6.5/debian/po/ro.po brltty-6.5/debian/po/ro.po
--- brltty-6.5/debian/po/ro.po 1970-01-01 01:00:00.000000000 +0100
+++ brltty-6.5/debian/po/ro.po 2023-02-12 15:02:11.000000000 +0100
@@ -0,0 +1,49 @@
+# Mesajele ?n limba rom?n? pentru pachetul brltty.
+# Romanian translation of brltty.
+# Copyright ? 2023 THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the brltty package.
+#
+# Remus-Gabriel Chelu <remusgabriel.chelu at disroot.org>, 2023.
+#
+# Cronologia traducerii fi?ierului ?brltty?:
+# Traducerea ini?ial?, f?cut? de R-GC, pentru versiunea brltty 6.5-6.
+# Actualizare a traducerii pentru versiunea Y, f?cut? de X, Y(anul).
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: brltty 6.5-6\n"
+"Report-Msgid-Bugs-To: brltty at packages.debian.org\n"
+"POT-Creation-Date: 2021-08-15 23:13+0200\n"
+"PO-Revision-Date: 2023-02-08 09:58+0100\n"
+"Last-Translator: Remus-Gabriel Chelu <remusgabriel.chelu at disroot.org>\n"
+"Language-Team: \n"
+"Language: ro\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=3; plural=(n==1 ? 0 : n==0 || (n!=1 && n%100>=1 && "
+"n%100<=19) ? 1 : 2);\n"
+"X-Generator: Poedit 3.2.2\n"
+
+# R-GC, scrie:
+# ini?ial, am tradus mesajul, ca:
+# ?Accesa?i programul de instalare folosind un afi?aj Braille?
+# *****
+# Dup? care am v?zut nota pt. traduc?tori,
+# de limitare a mesajului la
+# 55 de caractere/coloane. A?a c? l-am
+# reformulat (49 de caractee):
+# ?Accesa?i instalatorul folosind un afi?aj Braille?
+# ======
+# Sau, alternativ (53 de caractere):
+# ?Accesa?i instalatorul de Debian cu un afi?aj Braille?
+# -----------------------------
+# Opinii/Sugestii?
+#. Type: text
+#. Description
+#. Main menu item
+#. MUST be kept below 55 characters/columns
+#. :sl1:
+#: ../brltty-udeb.templates:1001
+msgid "Access the installer using a Braille display"
+msgstr "Accesa?i programul de instalare folosind un afi?aj Braille"
More information about the Pkg-a11y-devel
mailing list