Bug#1051402: emacspeak fails byte-compile during install or upgrade since emacs 29

[Paul Gevers]

Package: emacspeak
Version: 53.0+dfsg-2
Severity: serious
Justification: fails to install

Hi,

emacs 29 migrated to testing some days ago and now emacspeak fails to
byte-compile its code.

With a bit of mental support on #debian-emacs (and confirmation that
it's not only on my system), I debugged this to

emacs -batch -q -no-site-file      -f package-initialize  --eval '(setq file-name-handler-alist nil gc-cons-threshold 64000000  load-source-file-function  nil)'   -l /usr/share/emacs/site-lisp/emacspeak/lisp/emacspeak-load-path.el -l /usr/share/emacs/site-lisp/emacspeak/lisp/emacspeak-loaddefs.el   -f batch-byte-compile emacspeak-proced.el
Putting child 0x563d0a1d88c0 (emacspeak-proced.elc) PID 305986 on the chain.
Live child 0x563d0a1d88c0 (emacspeak-proced.elc) PID 305986 

In toplevel form:
emacspeak-proced.el:156:4: Error: Misplaced t or ‘otherwise’ clause
Reaping losing child 0x563d0a1d88c0 PID 305986 
make[1]: *** [Makefile:57: emacspeak-proced.elc] Error 1
Removing child 0x563d0a1d88c0 PID 305986 from chain.
Reaping losing child 0x563440648910 PID 305788 
make: *** [Makefile:50: emacspeak] Error 2
Removing child 0x563440648910 PID 305788 from chain.

It's not unlikely that this is solved in a new upstream version, which
I recall I tried to package earlier already but it had issues.

The dear people from #debian-emacs pasted a stand alone reproducer as
well:

(require 'cl-lib)
(defun emacspeak-proced-speak-that-field ()
  "Speak desired field via single keystroke."
  (interactive)
  (cl-case (read-char "?")
    (?u (emacspeak-proced-speak-field 'user))
    (?p (emacspeak-proced-speak-field 'pid))
    (?c (emacspeak-proced-speak-field 'pcpu))
    (?m (emacspeak-proced-speak-field 'pmem))
    (?v (emacspeak-proced-speak-field 'vsz))
    (?r (emacspeak-proced-speak-field 'rss))
    (?T (emacspeak-proced-speak-field 'tty))
    (?S (emacspeak-proced-speak-field 'stat))
    (?s (emacspeak-proced-speak-field 'start))
    (?t (emacspeak-proced-speak-field 'time))
    (?a (emacspeak-proced-speak-field 'args))
    (otherwise (message "Pick field using mnemonic chars"))
    (sit-for 1)))

Paul

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.4.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages emacspeak depends on:
ii  adduser                3.137
ii  debconf [debconf-2.0]  1.5.82
ii  emacs                  1:29.1+1-5
ii  emacs-gtk [emacs]      1:29.1+1-5
ii  make                   4.3-4.1
ii  perl                   5.36.0-7
ii  tcl                    8.6.13
ii  tclx8.4                8.4.1-4

Versions of packages emacspeak recommends:
ii  emacspeak-espeak-server  53.0+dfsg-2
ii  sox                      14.4.2+git20190427-3.5

Versions of packages emacspeak suggests:
pn  eflite        <none>
pn  emacspeak-ss  <none>
pn  espeak        <none>
pn  psgml         <none>
pn  w3m-el        <none>
ii  xsltproc      1.1.35-1

-- debconf information:
  shared/emacspeak/program: espeak
* shared/emacspeak/device: espeak
  shared/emacspeak/rootgroup:
* shared/emacspeak/port: none
  shared/emacspeak/fake:
  shared/emacspeak/database:
  shared/emacspeak/groupies:
  shared/emacspeak/tcl: tcl
  shared/emacspeak/invalidport:
  shared/emacspeak/invaliduser: