Bug#1066262: pyatspi: FTBFS: ../../../tests/dummyatk/my-atk-streamable-content.c:61:36: error: implicit declaration of function ‘T2C_GET_DATA_PATH’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: pyatspi
Version: 2.46.0-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../tests/dummyatk -I../..   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -I../../.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o libdummyatk_la-my-atk-streamable-content.lo `test -f 'my-atk-streamable-content.c' || echo '../../../tests/dummyatk/'`my-atk-streamable-content.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../tests/dummyatk -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../.. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c ../../../tests/dummyatk/my-atk-streamable-content.c  -fPIC -DPIC -o .libs/libdummyatk_la-my-atk-streamable-content.o
> ../../../tests/dummyatk/my-atk-streamable-content.c: In function ‘my_atk_streamable_content_get_stream’:
> ../../../tests/dummyatk/my-atk-streamable-content.c:61:36: error: implicit declaration of function ‘T2C_GET_DATA_PATH’ [-Werror=implicit-function-declaration]
>    61 |             gchar* full_filename = T2C_GET_DATA_PATH(file_names[i]);
>       |                                    ^~~~~~~~~~~~~~~~~
> ../../../tests/dummyatk/my-atk-streamable-content.c:61:36: warning: initialization of ‘gchar *’ {aka ‘char *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> ../../../tests/dummyatk/my-atk-streamable-content.c:65:17: error: implicit declaration of function ‘TRACE’ [-Werror=implicit-function-declaration]
>    65 |                 TRACE("Cannot open file '%s' for read: %s", full_filename,
>       |                 ^~~~~
> cc1: some warnings being treated as errors
> make[5]: *** [Makefile:549: libdummyatk_la-my-atk-streamable-content.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pyatspi_2.46.0-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.