Bug#1075690: xvkbd: ftbfs with GCC-14

[Matthias Klose]

Package: src:xvkbd
Version: 4.1-2
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/xvkbd_4.1-2_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
xvkbd.c: In function ‘AddToCompletionText’:
xvkbd.c:1595:34: error: passing argument 2 of ‘XawListChange’ from incompatible pointer type [-Wincompatible-pointer-types]
 1595 |   XawListChange(completion_list, word_list, 0, 0, TRUE);
      |                                  ^~~~~~~~~
      |                                  |
      |                                  char **
In file included from xvkbd.c:47:
/usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but argument is of type ‘char **’
  170 |  _Xconst char           **list,
      |                           ^
xvkbd.c: In function ‘PopupCompletionPanel’:
xvkbd.c:1721:34: error: passing argument 2 of ‘XawListChange’ from incompatible pointer type [-Wincompatible-pointer-types]
 1721 |   XawListChange(completion_list, word_list, 0, 0, TRUE);
      |                                  ^~~~~~~~~
      |                                  |
      |                                  char **
/usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but argument is of type ‘char **’
  170 |  _Xconst char           **list,
      |                           ^
xvkbd.c: In function ‘PropsItemToggled’:
xvkbd.c:2359:31: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 2359 |   appres.key_click_duration = (int)XawToggleGetCurrent(click_buttons);
      |                               ^
xvkbd.c:2360:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 2360 |   appres.autoclick_delay = (int)XawToggleGetCurrent(autoclick_buttons);
      |                            ^
xvkbd.c: In function ‘PropsSetState’:
xvkbd.c:2402:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2402 |   XawToggleSetCurrent(click_buttons, (XtPointer)appres.key_click_duration);
      |                                      ^
xvkbd.c:2403:42: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2403 |   XawToggleSetCurrent(autoclick_buttons, (XtPointer)appres.autoclick_delay);
      |                                          ^
xvkbd.c: In function ‘PopupPropsPanel’:
xvkbd.c:2460:46: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2460 |                                XtNradioData, (XtPointer)val,
      |                                              ^
xvkbd.c:2482:46: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2482 |                                XtNradioData, (XtPointer)val,
      |                                              ^
xvkbd.c:2486:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 2486 |                     (XtPointer)val);
      |                     ^
xvkbd.c: In function ‘main’:
xvkbd.c:4037:69: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
 4037 |     fprintf(stdout, "%s, compiled %s\n", PROGRAM_NAME_WITH_VERSION, __DATE__);
      |                                                                     ^~~~~~~~
xvkbd.c: In function ‘KeyPressed’:
xvkbd.c:2806:27: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2806 |       if (!appres.secure) system(value + 1);
      |                           ^~~~~~~~~~~~~~~~~
xvkbd.c:2986:33: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2986 |             if (!appres.secure) system("xvidtune -next");
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
xvkbd.c:2988:33: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2988 |             if (!appres.secure) system("xvidtune -prev");
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
xvkbd.c: In function ‘MenuSelected’:
xvkbd.c:2608:25: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2608 |     if (!appres.secure) system(appres.show_manual_command);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:511: xvkbd-xvkbd.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:584: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:378: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:9: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2