Bug#1136500: emacspeak uses pidof but does not depend on procps

[Gioele Barabucci]

Source: emacspeak
Version: 53.0+dfsg-5
Usertags: pidof-without-procps

Dear maintainer(s) of emacspeak,

it appears that emacspeak uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of emacspeak
  that use `pidof` at runtime;
* via the `Build-Depends:` field of emacspeak, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of emacspeak, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that emacspeak uses `pidof` due to the following
code snippets:

```
path: emacspeak_53.0+dfsg-5/etc/cbox-amp
pidof Xvfb ||  nice -n 15 Xvfb -ac :5 -screen 0 800x200x16 &
export DISPLAY=:5
nice -n 15 google-chrome --alsa-output-device=amp --remote-debugging-port=9222 "$@"  2>&1 > /dev/null &


path: emacspeak_53.0+dfsg-5/etc/cbox-right
pidof Xvfb ||  nice -n 19 Xvfb -ac :5 -screen 0 800x200x16 &
export DISPLAY=:5
nice -n 19 google-chrome-unstable --alsa-output-device=tts_mono_right --remote-debugging-port=9222 "$@"  2>&1 > /dev/null &


path: emacspeak_53.0+dfsg-5/lisp/emacspeak-dbus.el
      (progn
        (shell-command
         "pidof gnome-screensaver \
 && kill -9 `pidof gnome-screensaver` 2>&1 > /dev/null")
        (start-process "screen-saver" nil "gnome-screensaver"))))


path: emacspeak_53.0+dfsg-5/etc/cbox-left
pidof Xvfb ||  nice -n 15 Xvfb -ac :5 -screen 0 800x200x16 &
export DISPLAY=:5
nice -n 15 google-chrome-unstable --alsa-output-device=soft_left --remote-debugging-port=9222 "$@"  2>&1 > /dev/null &


path: emacspeak_53.0+dfsg-5/stumpwm/xsession
xmodmap $HOME/.xmodmap 
#xcape  # -t 125 #-e 'Control_L=Escape'
pidof ibus && ibus exit
xset b 100 440
xset dpms


path: emacspeak_53.0+dfsg-5/etc/cbox
pidof Xvfb ||  nice -n 15 Xvfb -ac :5 -screen 0 800x200x16 &
export DISPLAY=:5
nice -n 19 google-chrome-unstable  --remote-debugging-port=9222 "$@"  2>&1 > /dev/null &
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci