[Pkg-acpi-devel] Bug#500003: acpid: broken DISTRO test in /etc/init.d/acpi

Julien Cristau jcristau at debian.org
Wed Sep 24 08:35:34 UTC 2008


Package: acpid
Version: 1.0.6-12
Severity: important

if `grep -q ubuntu /etc/apt/sources.list`; then
        DISTRO=Ubuntu
else
        DISTRO=Debian
fi

This test is utterly broken, it's pretty much equivalent to 'if false'
(you'd want to remove the backquotes).

But, even then, that test is conceptually broken:
- it doesn't actually test whether we're on ubuntu or debian (or some entirely
  different derivative)
- the test should be done at package build time, not at run time
- apt is not Required

Please fix this.

Cheers,
Julien

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages acpid depends on:
ii  libc6                         2.7-13     GNU C Library: Shared libraries
ii  lsb-base                      3.2-20     Linux Standard Base 3.2 init scrip
ii  module-init-tools             3.4-1      tools for managing Linux kernel mo

acpid recommends no packages.

acpid suggests no packages.

-- no debconf information





More information about the Pkg-acpi-devel mailing list