[Pkg-acpi-devel] Bug#500659: acpid: init script will fail if /proc/modules does not exist

[Sven Joachim]

Package: acpid
Version: 1.0.6-13
Severity: normal
Tags: patch

It is a bad idea to use the syntax

    [ -f /proc/modules ] && load_modules

in /etc/init.d/acpid, since that causes immediate failure of the script
if /proc/modules does not exist (such as in non-modular kernels).

Please use the following syntax instead:

--8<---------------cut here---------------start------------->8---
--- acpid.init.d.in~	2008-09-24 13:34:03.000000000 +0200
+++ acpid.init.d.in	2008-09-30 09:37:50.000000000 +0200
@@ -90,7 +90,7 @@
 
 case "$1" in
   start)
-    [ -f /proc/modules ] && load_modules
+    if [ -f /proc/modules ]; then load_modules; fi
     log_begin_msg "Starting ACPI services..."
     start-stop-daemon --start --quiet --oknodo --exec /usr/sbin/acpid -- $OPTIONS
     log_end_msg $?
--8<---------------cut here---------------end--------------->8---


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26.5-libata
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages acpid depends on:
ii  libc6                         2.7-13     GNU C Library: Shared libraries
ii  lsb-base                      3.2-20     Linux Standard Base 3.2 init scrip
ii  module-init-tools             3.4-1      tools for managing Linux kernel mo

acpid recommends no packages.

acpid suggests no packages.

-- no debconf information